Problem/Motivation

It can be unclear what the different options on the "Style" selector mean - does "Search results" mean core's "search result" view mode, what template is used, etc?

Proposed resolution

Rename the "Style" selector to say "Output style".
Reword the "Style" selector's options to say "Standard entity view mode" and "Use search-ap-page-result.html.twig" (or maybe something else?).

Remaining tasks

Do the thing.

User interface changes

The "Style" selector's options are renamed.

API changes

n/a

Data model changes

n/a

CommentFileSizeAuthor
#4 after_patch.png49.96 KBtanuja bohra
#4 before_patch.png41.65 KBtanuja bohra
#3 search_api_page-n3367531-3.patch791 bytesdamienmckenna

Issue fork search_api_page-3367531

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Title: Clarify "style" selector wording » Clarify "Style" selector wording
Issue summary: View changes
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new search_api_page-n3367531-3.patch791 bytes

As suggested.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png41.65 KB
new after_patch.png49.96 KB

Verified the #3 patch, the words are updated. Added screenshots for reference, RTBC++.

karlshea made their first commit to this issue’s fork.

karlshea opened merge request !22

  • karlshea committed 1995e9e7 on 8.x-1.x 
    feat: #3367531 Clarify "Style" selector wording

By: damienmckenna
By:...
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.