FILE: D:\xampp\htdocs\drupal_10\web\modules\contrib\block_class\src\Service\BlockClassHelperService.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
593 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#3 with patch.png114.76 KBkenyoowen
#3 without patch.png102.69 KBkenyoowen
#2 3366420-2.patch2.43 KBarti_parmar

Issue fork block_class-3366420

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arti_parmar created an issue. See original summary.

arti_parmar’s picture

arti_parmar commented
Assigned: arti_parmar » Unassigned
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new 3366420-2.patch2.43 KB

Kindly review patch.

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new without patch.png102.69 KB
new with patch.png114.76 KB

Hi arti_parmar

I reviewed and applied your patch and confirmed that the issue mentioned is resolved. Please see the screenshots attached.

Thank you.

apaderno made their first commit to this issue’s fork.

apaderno opened merge request !34

apaderno opened merge request !35

apaderno changed the visibility of the branch 3366420-drupal-calls-should-be-avoided to hidden.

apaderno changed the visibility of the branch 3366420--drupal-calls to hidden.

apaderno opened merge request !36

DYdave made their first commit to this issue’s fork.

dydave’s picture

dydave commented
Related issues: +#3392942: Fix the issues reported by phpcs
dydave’s picture

dydave commented
Status: Reviewed & tested by the community » Closed (outdated)

No activity on issue for more than a year.

This has most likely been fixed in other issues since there are no more calls to \Drupal.

Additionally, PHPSTAN, PHPCS and PHPUNIT jobs are all happy.

Marking issue as Closed (outdated) for now.

Thanks again very much for the great work!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

dydave closed merge request !36

dydave closed merge request !34

dydave closed merge request !35