Needs review
Project:
Obfuscate
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2023 at 10:01 UTC
Updated:
5 Feb 2025 at 14:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mrshowermanI noticed that the query string is available in the
$extraarray, whose contents are added to the resulting<a>element as HTML attributes. The attached patch fixes the issue by adding the query string to the URL instead and removing it from the array. Also, I noticed a few code inconsistencies introduced by the latest rewrite, which I tried to fix as well.Comment #3
mrshowermanComment #5
mrshowermanI noticed that in the HTML method, there were a few attributes added to the link that aren't valid HTML, like
type="mailto". On the other hand, other valid attributes got lost in thepreandpostkeys that were not processed properly.Created an MR that fixes both on top of the original patch.