Webform #Element_validate: Unsupported operand types [#3366295]

Problem/Motivation

We are using the Webform Element in a form on our site and we are getting a error on submission. The error is as follows:

TypeError: Unsupported operand types: array + null in Drupal\office_hours\Element\OfficeHoursBaseSlot::validateOfficeHoursSlot() (line 247 of modules/contrib/office_hours/src/Element/OfficeHoursBaseSlot.php).
Drupal\office_hours\Element\OfficeHoursBaseSlot::validateOfficeHoursSlot(Array, Object, Array) (Line: 165)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours::validateOfficeHoursSlot(Array, Object, Array)
call_user_func_array(Array, Array) (Line: 282)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'webform_submission_one_to_one_learner_registration__test_form') (Line: 118)
Drupal\Core\Form\FormValidator->validateForm('webform_submission_one_to_one_learner_registration__test_form', Array, Object) (Line: 593)
Drupal\Core\Form\FormBuilder->processForm('webform_submission_one_to_one_learner_registration__test_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'test') (Line: 1249)
Drupal\webform\Entity\Webform->getSubmissionForm(Array, 'test') (Line: 128)
Drupal\webform\Controller\WebformTestController->testForm(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

As far as the config options for the element itself, this error persists no matter what options one chooses for it when building the form.

Steps to reproduce

Create a webform (or edit an existing form)
Add an Office Hours element to the form
Attempt a test submission for the form

Comment	File	Size	Author
#20	office_hours_3366295-20_webformsettings.patch	1.89 KB	johnv
#19	office_hours_3366295-19_settings.patch	5.52 KB	johnv
#16	office_hours_3366295-16_day.patch	802 bytes	johnv
#13	office_hours_3366295-13_bool+array.patch	1008 bytes	johnv
#4	office_hours_3366295-4_array+null.patch	630 bytes	johnv

Issue fork office_hours-3366295

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3366295-elementvalidate-unsupported-operand compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

12 June 2023 at 20:02

LordBarnhill created an issue. See original summary.

Comment #2

lordbarnhill commented 12 June 2023 at 20:05

Issue summary:

View changes

Comment #3

johnv

Dutch

commented 13 June 2023 at 07:39

Title:

Webform Element Unsupported operand types: array + null

» '#Element_validate' Unsupported operand types: array + null

How com thisis a new error?
- new installation,
- upgrade of PHP version? (What is you current PHP version, since checks are more strict)
- upgrade of Office hours module?
working on the problem..

Comment #4

johnv

Dutch

commented 13 June 2023 at 07:47

Status:

Active

» Needs review

Status	File	Size
new	office_hours_3366295-4_array+null.patch	630 bytes

Comment #5

13 June 2023 at 14:13

johnv committed 4d748dca on 8.x-1.x

Issue #3366295: #Element_validate: Unsupported operand types: array +...

Comment #6

johnv

Dutch

commented 13 June 2023 at 14:17

Title:	'#Element_validate' Unsupported operand types: array + null	» #Element_validate: Unsupported operand types: array + null
Status:	Needs review	» Fixed

This should be fixed. Please test newest DEV-version, or above patch.

Comment #7

lordbarnhill commented 13 June 2023 at 14:52

Thanks for the quick response! I tested with the patch from #4 and got the following error:

TypeError: Unsupported operand types: bool + array in Drupal\office_hours\Plugin\Field\FieldFormatter\OfficeHoursFormatterBase->mergeDefaults() (line 99 of modules/contrib/office_hours/src/Plugin/Field/FieldFormatter/OfficeHoursFormatterBase.php).
Drupal\office_hours\Plugin\Field\FieldFormatter\OfficeHoursFormatterBase->mergeDefaults() (Line: 51)
Drupal\Core\Field\PluginSettingsBase->getSettings() (Line: 45)
Drupal\office_hours\Plugin\Field\FieldFormatter\OfficeHoursFormatterDefault->viewElements(Object, NULL) (Line: 208)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours->viewElements(Array, Object, Array) (Line: 232)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours->formatTextItem(Array, Object, Array) (Line: 1377)
Drupal\webform\Plugin\WebformElementBase->format('Text', Array, Object, Array) (Line: 1334)
Drupal\webform\Plugin\WebformElementBase->formatText(Array, Object, Array) (Line: 356)
Drupal\webform\Plugin\WebformElement\WebformCompositeBase->formatText(Array, Object, Array) (Line: 1295)
Drupal\webform\Plugin\WebformElementBase->build('text', Array, Object, Array) (Line: 1274)
Drupal\webform\Plugin\WebformElementBase->buildText(Array, Object, Array) (Line: 196)
Drupal\webform\WebformSubmissionViewBuilder->buildElements(Array, Object, Array, 'text') (Line: 193)
Drupal\webform\Plugin\WebformElement\ContainerBase->formatTextItem(Array, Object, Array) (Line: 1377)
Drupal\webform\Plugin\WebformElementBase->format('Text', Array, Object, Array) (Line: 1334)
Drupal\webform\Plugin\WebformElementBase->formatText(Array, Object, Array) (Line: 83)
Drupal\webform\Plugin\WebformElement\ContainerBase->build('text', Array, Object, Array) (Line: 1274)
Drupal\webform\Plugin\WebformElementBase->buildText(Array, Object, Array) (Line: 196)
Drupal\webform\WebformSubmissionViewBuilder->buildElements(Array, Object, Array, 'text') (Line: 1119)
_webform_token_get_submission_values(Array, Object) (Line: 599)
webform_tokens('webform_submission', Array, Array, Array, Object)
call_user_func_array(Object, Array) (Line: 426)
Drupal\Core\Extension\ModuleHandler->Drupal\Core\Extension\{closure}(Object, 'webform') (Line: 405)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('tokens', Object) (Line: 433)
Drupal\Core\Extension\ModuleHandler->invokeAll('tokens', Array) (Line: 359)
Drupal\Core\Utility\Token->generate('webform_submission', Array, Array, Array, Object) (Line: 241)
Drupal\Core\Utility\Token->doReplace(1, 'Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]

Submitted values are:
[webform_submission:values]
', Array, Array, Object) (Line: 191)
Drupal\Core\Utility\Token->replace('Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]

Submitted values are:
[webform_submission:values]
', Array, Array, Object) (Line: 154)
Drupal\webform\WebformTokenManager->replace('Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]

Submitted values are:
[webform_submission:values]
', Object, Array, Array, Object) (Line: 173)
Drupal\webform\WebformTokenManager->replaceNoRenderContext('Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]

Submitted values are:
[webform_submission:values]
', Object, Array, Array) (Line: 746)
Drupal\webform\Plugin\WebformHandlerBase->replaceTokens('Submitted on [webform_submission:created]
Submitted by: [webform_submission:user]

Submitted values are:
[webform_submission:values]
', Object, Array, Array) (Line: 930)
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->getMessage(Object) (Line: 857)
Drupal\webform\Plugin\WebformHandler\EmailWebformHandler->postSave(Object, , NULL) (Line: 2757)
Drupal\webform\Entity\Webform->invokeHandlers('postSave', Object, , NULL) (Line: 1212)
Drupal\webform\WebformSubmissionStorage->invokeWebformHandlers('postSave', Object, ) (Line: 1120)
Drupal\webform\WebformSubmissionStorage->doPostSave(Object, ) (Line: 523)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 804)
Drupal\Core\Entity\Sql\SqlContentEntityStorage->save(Object) (Line: 983)
Drupal\webform\WebformSubmissionStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 901)
Drupal\webform\Entity\WebformSubmission->save() (Line: 1995)
Drupal\webform\WebformSubmissionForm->save(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('webform_submission_one_to_one_learner_registration__test_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'test') (Line: 1249)
Drupal\webform\Entity\Webform->getSubmissionForm(Array, 'test') (Line: 128)
Drupal\webform\Controller\WebformTestController->testForm(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

To answer you questions from #3:
- This is on an existing site, not a new installation
- The PHP version is 8.1
- We recently updated the Office Hours module from 8.x-1.8 (I believe) to 8.x-1.9

Comment #8

lordbarnhill commented 13 June 2023 at 14:53

Status:

Fixed

» Needs review

Comment #9

lordbarnhill commented 13 June 2023 at 15:04

Status:

Needs review

» Needs work

Comment #10

johnv

Dutch

commented 13 June 2023 at 16:11

hmm.

I guess there is some 'strict_typing' activated by one of your installed modules.
And as you have only 1 error at a time, this will bounce more often. :-(

Can you debug and check what is the contents of '$this->settings['exceptions']' ?
Else, you can save the field formatter settings. That should fix the problem , too. But that is not solution for other people with your settings.

Comment #11

lordbarnhill commented 13 June 2023 at 18:44

The content of $this->settings['exceptions'] is showing to be FALSE.

Comment #12

13 June 2023 at 22:10

Ahmad Smhan made their first commit to this issue’s fork.

Comment #13

johnv

Dutch

commented 14 June 2023 at 06:34

Status:

Needs work

» Needs review

Status	File	Size
new	office_hours_3366295-13_bool+array.patch	1008 bytes

Please see attached patch for this new occasion.

Comment #14

14 June 2023 at 06:37

johnv committed 2512469f on 8.x-1.x

Issue #3366295 by Ahmad Smhan: #Element_validate: Unsupported operand...

Comment #15

lordbarnhill commented 14 June 2023 at 15:04

Using both the #4 and #13 patches allowed the form to be submitted successfully. However, now I am seeing an error when trying to view the submission:

The website encountered an unexpected error. Please try again later.
TypeError: Drupal\Core\TypedData\TypedDataManager::create(): Argument #1 ($definition) must be of type Drupal\Core\TypedData\DataDefinitionInterface, null given, called in /app/web/modules/contrib/office_hours/src/Plugin/WebformElement/WebformOfficeHours.php on line 384 in Drupal\Core\TypedData\TypedDataManager->create() (line 99 of core/lib/Drupal/Core/TypedData/TypedDataManager.php).
Drupal\Core\TypedData\TypedDataManager->create(NULL, Array, 'availability', Object) (Line: 384)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours->unserialize(Array, Array, Object) (Line: 194)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours->viewElements(Array, Object, Array) (Line: 219)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours->formatHtmlItem(Array, Object, Array) (Line: 1377)
Drupal\webform\Plugin\WebformElementBase->format('Html', Array, Object, Array) (Line: 1327)
Drupal\webform\Plugin\WebformElementBase->formatHtml(Array, Object, Array) (Line: 344)
Drupal\webform\Plugin\WebformElement\WebformCompositeBase->formatHtml(Array, Object) (Line: 279)
Drupal\webform\Plugin\WebformElement\WebformCompositeBase->formatTableColumn(Array, Object, Array) (Line: 1001)
Drupal\webform\WebformSubmissionListBuilder->buildRowColumn(Array, Object) (Line: 834)
Drupal\webform\WebformSubmissionListBuilder->buildRow(Object) (Line: 219)
Drupal\Core\Entity\EntityListBuilder->render() (Line: 559)
Drupal\webform\WebformSubmissionListBuilder->buildEntityList() (Line: 454)
Drupal\webform\WebformSubmissionListBuilder->render() (Line: 23)
Drupal\Core\Entity\Controller\EntityListController->listing('webform_submission')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I am also seeing a warning after submitting the form:

Warning: Undefined array key "day" in Drupal\office_hours\Element\OfficeHoursBaseSlot::validateOfficeHoursSlot() (line 243 of modules/contrib/office_hours/src/Element/OfficeHoursBaseSlot.php).
Drupal\office_hours\Element\OfficeHoursBaseSlot::validateOfficeHoursSlot(Array, Object, Array) (Line: 165)
Drupal\office_hours\Plugin\WebformElement\WebformOfficeHours::validateOfficeHoursSlot(Array, Object, Array)
call_user_func_array(Array, Array) (Line: 282)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object) (Line: 238)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'webform_submission_one_to_one_learner_registration__test_form') (Line: 118)
Drupal\Core\Form\FormValidator->validateForm('webform_submission_one_to_one_learner_registration__test_form', Array, Object) (Line: 593)
Drupal\Core\Form\FormBuilder->processForm('webform_submission_one_to_one_learner_registration__test_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 48)
Drupal\Core\Entity\EntityFormBuilder->getForm(Object, 'test') (Line: 1249)
Drupal\webform\Entity\Webform->getSubmissionForm(Array, 'test') (Line: 128)
Drupal\webform\Controller\WebformTestController->testForm(Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 169)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 81)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 718)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comment #16

johnv

Dutch

commented 15 June 2023 at 08:47

Status	File	Size
new	office_hours_3366295-16_day.patch	802 bytes

Unfortunately, I cannot reproduce your problem, working with Drupal 9.5.x and latest Webform version and PHP8.2.

Yesterday, a new version 1.11 is released. Please test again with that release.

Please also see attached new patch, regarding Warning: Undefined array key "day" . I will commit that change shortly.

I created Webformsubmissions from beow pages, and none call the viewElements() function. Only prepare() is called.
/form/TYPE
/webform/TYPE/test

Can you state your complete test script? I think is is used when downloading webform submissions.

Comment #17

15 June 2023 at 08:56

johnv committed fe26c7e4 on 8.x-1.x

Issue #3366295: Warning: Undefined array key 'day' in...

Comment #18

johnv

Dutch

commented 15 June 2023 at 09:40

OK, your error appears on the following page:
admin/structure/webform/manage/TYPE/results/submissions

Comment #19

johnv

Dutch

commented 15 June 2023 at 11:17

Status	File	Size
new	office_hours_3366295-19_settings.patch	5.52 KB

Please test attached patch.
Or download dev, since I will commit it shortly.

Comment #20

johnv

Dutch

commented 15 June 2023 at 11:19

Status	File	Size
new	office_hours_3366295-20_webformsettings.patch	1.89 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	office_hours_3366295-19_settings.patch	5.52 KB

Comment #21

15 June 2023 at 11:21

johnv committed 055745e6 on 8.x-1.x

Issue #3366295: WebformOfficeHours->unserialize error

Comment #22

15 June 2023 at 13:10

johnv committed ee0317b7 on 8.x-1.x

Issue #3366295: WebformOfficeHours refactoring

Comment #23

15 June 2023 at 13:37

johnv committed 03dac3d0 on 8.x-1.x

Issue #3366295: WebformOfficeHours->viewElements() refactoring

Comment #24

lordbarnhill commented 15 June 2023 at 15:59

I tested with the newest version (v1.11) and the patches from #16 and #20 and all the errors seem to be resolved! I am now able to submit the form successfully and view the submissions at admin/structure/webform/manage/TYPE/results/submissions. Thank you for being so responsive with this issue!

Comment #25

johnv

Dutch

commented 16 June 2023 at 07:49

De nada.

Comment #26

johnv

Dutch

commented 16 June 2023 at 07:50

Title:	#Element_validate: Unsupported operand types: array + null	» Webform #Element_validate: Unsupported operand types
Version:	8.x-1.9	» 8.x-1.11
Status:	Needs review	» Fixed

Comment #27

30 June 2023 at 07:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Webform #Element_validate: Unsupported operand types

Problem/Motivation

Steps to reproduce

Issue fork office_hours-3366295

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

Comment #25

Comment #26

Comment #27

News items

Our community

Documentation

Drupal code base

Governance of community