Problem/Motivation
The module affects normal files download behavior.
When opening Media documents, they download instead of being opened in new window (as it works by default for PDFs).
Steps to reproduce
1. Install Drupal, enable Media module.
2. Create the Media file with PDF.
3. Go to /admin/content/files
4. Click the PDF file link. Observe the PDF being opened in new tab.
5. Install single_content_sync module.
6. Click the same PDF file link.
Expected: the file opens at new tab.
Actual: the file is being downloaded.
Proposed resolution
Update the single_content_sync_file_download function to only affect file download routes added by the module.
| Comment | File | Size | Author |
|---|
Issue fork single_content_sync-3366216
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
foxy-vikvik commentedComment #6
foxy-vikvik commentedPatch from MR
Comment #7
foxy-vikvik commentedComment #8
foxy-vikvik commentedComment #9
abrammComment #10
abrammComment #11
abrammComment #12
abrammComment #13
abrammRebased the MR over 1.4.x.
Comment #16
abrammMerged the fix to 1.4.x and cherry-picked to 1.3.x since it's a bug.
Thank you Foxy-vikvik!