Argh!!! Yet again, I have to waste time fixing a bug because of the whole incredibly stupid node-type vs. node_type crap that was introduced in D6 core. KILL!

#329668: Improve warning messages when CCK date fields are misconfigured is broken if you have a node type with an underscore in the machine name, since the edit page is admin/content/node-type/[node-type] instead of admin/content/node-type/[node_type].

Grrrrrr....

CommentFileSizeAuthor
#3 336610_node_type_url.3.D5.patch1.86 KBdww
#3 336610_node_type_url.3.D6.patch1.87 KBdww
#2 336610_node_type_url.2.D6.patch1.15 KBdww
#2 336610_node_type_url.2.D5.patch1.15 KBdww

Comments

dww’s picture

dww
we/he/they
commented
Title: Stupid D6 core node-type vs. node_type insanity breaks help messages for node types with underscores » Stupid core node-type vs. node_type insanity breaks help messages for node types with underscores

Oh, right, this started in D5, not just D6. It's broken in DRUPAL-5--2 branch, too.

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
StatusFileSize
new 336610_node_type_url.2.D5.patch1.15 KB
new 336610_node_type_url.2.D6.patch1.15 KB
dww’s picture

dww
we/he/they
commented
StatusFileSize
new 336610_node_type_url.3.D6.patch1.87 KB
new 336610_node_type_url.3.D5.patch1.86 KB

Except that's still broken for the case where we're at admin/content/node-type/foo-bar since "foo-bar" isn't a valid type to check against! So, we have to convert from the URL back to the actual machine-readable name at that point. Argh!

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Committed to HEAD and DRUPAL-5--2.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.