Although an L10nPackagerFileInterface interface is defined, it is not used by the l10n_packager_file entity. Provided this interface is relevant (I believe it is), it should be implemented by L10nPackagerFile. We should then use it to type the third argument of L10nPackager::package().
Issue fork l10n_server-3365352
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
fmb commentedComment #3
elberHi I need more details I implemented the interface in L10nPackagerFile.php
class L10nPackagerFile extends ContentEntityBase implements L10nPackagerFileInterfacebut I had several errors like this'Drupal\l10n_packager\Entity\L10nPackagerFile' does not implement methods 'getRelease', 'setRelease', 'getReleaseId', 'setReleaseId', 'getLanguage', 'setLanguage', 'getFile', 'setFile', 'getFileId', 'setFileId', 'getStringCount', 'setStringCount', 'setCheckedTime'Do you want these methods be implemented in this class or am I doing something wrong.Comment #4
fmb commentedYes, these methods also need to be implemented, sorry about that. Thanks!
Comment #6
elberComment #8
fmb commentedThanks @elber! I had to rework some of it, for instance the part about project IDs, which are not directly related to this entity (it was not your fault, the interface was wrong in the first place).
Out of curiosity, how did you hear about this issue? During Drupalcon?
Comment #9
elberHi I just saw it in the issues queue.
It was a pleasure to work on it for me!