Closed (fixed)
Project:
Widget Ingestion
Version:
1.4.10
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Jun 2023 at 09:55 UTC
Updated:
15 Jun 2023 at 16:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
isholgueras commentedHere is the first patch.
In relation to the fix on tests, Sebastian suggest to fix the
$this->prophetizedeprecation by using thePropecyTraitfromphpspec/prophecy-phpunit. I've added it towidget_ingestion/composer.jsonas arequire-dev. Is this correct?Comment #3
isholgueras commentedUpgrade php requirement in composer.json to 8.1
Comment #4
isholgueras commentedThe required version of prohecy-phpunit was the 2.0-@dev
Comment #5
e0ipsoWhy are we skipping access checks here? I can't remember the exact context where this is called, but status is checked as TRUE so we maybe want access checks on.
I can't remember having to add a require-dev package for other Drupal 10 upgrades. Is it possible that the methods were added elsewhere?
Comment #6
sakthi_dev commentedCreated a patch based on #5. Please review.
Comment #8
e0ipsoComment #10
e0ipso