Problem/Motivation

This module is not compatible with Drupal 10 yet.

Proposed resolution

Fix deprecations using upgrade_status module and install and test in a plain Drupal 10

Remaining tasks

Fix:
- QueryInterface accessCheck is now required
- core_version_requirement to accept Drupal 10
- Fix prophetize deprecation and removal.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

isholgueras created an issue. See original summary.

isholgueras’s picture

Assigned: isholgueras » Unassigned
Status: Active » Needs review
StatusFileSize
new4.13 KB

Here is the first patch.

In relation to the fix on tests, Sebastian suggest to fix the $this->prophetize deprecation by using the PropecyTrait from phpspec/prophecy-phpunit. I've added it to widget_ingestion/composer.json as a require-dev. Is this correct?

isholgueras’s picture

StatusFileSize
new4.2 KB

Upgrade php requirement in composer.json to 8.1

isholgueras’s picture

StatusFileSize
new4.21 KB

The required version of prohecy-phpunit was the 2.0-@dev

e0ipso’s picture

Status: Needs review » Needs work
->accessCheck(FALSE)

Why are we skipping access checks here? I can't remember the exact context where this is called, but status is checked as TRUE so we maybe want access checks on.


I can't remember having to add a require-dev package for other Drupal 10 upgrades. Is it possible that the methods were added elsewhere?

sakthi_dev’s picture

Status: Needs work » Needs review
StatusFileSize
new4.2 KB

Created a patch based on #5. Please review.

e0ipso’s picture

  • e0ipso committed f94822f5 on 1.x
    Issue #3364094 by isholgueras, e0ipso, sakthi_dev: Drupal 10...
e0ipso’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.