Assigning a taxonomy to imported entries doesn't work [#336344]

To reproduce the bug, try to import a file (I tested with a bibtex file, but I think it doesn't matter the type):
- Assign a vocabulary to the Biblio content type first
- Go to page admin/settings/biblio/import. Under taxonomy settings, select a term under the vocabulary you assigned to the biblio content type
- Import the file
- Check that the imported nodes do not receive the term you tried to assign them.

I suspect that this is a problem in the file biblio.import.export.inc, in function biblio_import. In line 257, module_invoke passes to the function taxonomy_node_save the node id, but the taxonomy_node_save function expects the node object. I created a new variable that holds the loaded node and passed that variable to module_invoke instead, and it seems to be working.

Would anyone test this and/or submit a patch, or should I do it myself?

Thanks!

Comments

Comment #1

rjerome CreditAttribution: rjerome commented 19 November 2008 at 13:55

Assigned:

Unassigned

» rjerome

Thanks,

I'll take a look at it, no need for a patch.

Ron.

Comment #2

Eric Link CreditAttribution: Eric Link commented 3 December 2008 at 03:25

Hi Ron -

Great module, just what we needed.

I'm noticing this on the latest release download, should I be using the CVS HEAD version of the module or is this still being worked on?

Can I hack it out, where would I start?

Thanks

- Eric

Comment #3

rjerome CreditAttribution: rjerome commented 3 December 2008 at 13:44

Hi Eric,

This hasn't been resolved yet (I suspect it's not a big deal, I just haven't looked at it).

The assignment of keywords to taxonomy (when importing from a file) happens in biblio.import.export.inc in the biblio_save_imported_nodes() function starting at line 518.

One of the reasons I haven't looked at this yet is I will probably be abandoning saving the keywords in the biblio table and using taxonomy exclusively.

Ron.

Comment #4

Eric Link CreditAttribution: Eric Link commented 16 December 2008 at 01:02

Thanks Ron. Yeah, that makes sense (storing them in using taxonomy). Any thoughts on when you might do another release? Thanks, our client loves the biblio module!

Comment #5

rjerome CreditAttribution: rjerome commented 16 December 2008 at 03:08

I'll probably have a release candidate tomorrow.

BTW, the original issue is also fixed.

Ron.

Comment #6

Eric Link CreditAttribution: Eric Link commented 17 December 2008 at 06:22

And indeed the release candidate is here, cool!

I've installed it and we'll try this out.

Thanks for the release,

- Eric

Comment #7

masood_mj CreditAttribution: masood_mj commented 7 January 2009 at 12:23

Version:

6.x-1.0-beta8

» 6.x-1.0-rc2

It doesn't work for me! I selected a taxonomy item in the biblio import but it the imported contents don't have the key. (The field is an additional field besides the biblio keywords = an additional vocabulary assigned for the biblio content type)

Comment #8

bmenk CreditAttribution: bmenk commented 7 January 2009 at 16:09

Ron

Per your advice to me on Drupal4Lib, I created a new taxonomy called Bibliography Names and assigned it to the content type of Biblio, and have run into two issues trying to use it.

1. When I open the Taxonomy section of the Biblio import form, I expected to be able to start typing a new tag into the Bibliography Names box as this taxonomy is defined as "Tags" so that users should be able to create a name for a bibliography on the fly. However all I can do is click a drop down.

2. To test my other issue of assigning a term from the Bibliography Names taxonomy to an entire set of citations as they're being imported, I manually edited this taxonomy to have a term in it to work with. Then I imported an RIS file, telling it to use the term I just added. The end result was that the term from the Bibliography Names taxonomy did not get associated with the newly imported items, nor did they import as the user I was logged in as, but as the main admin user.

Suggestions? Advice?

Thanks.

Bobb Menk

Comment #9

rjerome CreditAttribution: rjerome commented 7 January 2009 at 16:24

Hi Bobb,

In answer to your questions...

The reasoning for a drop down list in the taxonomy section is so that a "Controlled" list of terms can be applied other wise users might pick different (but similar) terms to refer to the same thing. Also the idea of this particular tag is to "categorize" a group of entries, and again I think this categorization needs to be consistent. Granted if there is only one person doing the entries, then it does incur the extra overhead of creating/modifying the term list separately but I guess you can't win them all :-)

There is currently a couple of issues which have just come to light surrounding the very things you are trying to do. I have just fixed the issue of entries being attributed to the admin user, it was reported here... http://drupal.org/node/355480 and there is still an issue assigning tags to imported entries which has also just come to light. So basically I lied to you when I said it could be done, but you will be able to shortly :-)

Ron.

Comment #10

bmenk CreditAttribution: bmenk commented 7 January 2009 at 18:17

Ron

Thanks for the quick reply!

My thinking with the free tagging vs. drop down was that I wanted my librarians to be able to give a bibliography that's being created for a patron the chance to just name it on the fly. The life of the bibliography would be relatively brief so consistent controlled vocabulary for tagging them was less important to me than generating a tag that would label a large group of citations by something recognizable for the patron. Kind of "Search Web Of Science" > save results > upload to Drupal > send link to patron saying "Your bibliography on topic X is ready" at a given URL.

We can certainly live with the way it is now, but from the point of view of the process we normally use, it adds an extra step.

I'll check back to see when the other issue is resolved.

Thanks again for your efforts.

Bobb Menk

Comment #11

rjerome CreditAttribution: rjerome commented 7 January 2009 at 18:45

Ok, I see where you are coming from now. I suppose I could add this feature as well, perhaps with an option to turn it on and off, for those who don't want it.

By the way I just tracked down and squished the bugs that were preventing these tags from being assigned in the first place. You will find these fixes in the next -dev version when it is built (every 12 hours).