Drupal 10 compatibility [#3363278]

Problem/Motivation

Drupal 10 compatibility issues

Comment	File	Size	Author
#7	gtm-datalayer-d10-compatibility-3363278-7.patch	595 bytes	jmaties
#4	Screenshot from 2023-05-29 14-12-31.png	20.13 KB	dineshkumarbollu
#2	gtm-datalayer-d10-compatibility-3363278-2.patch	4.64 KB	yogeshsevak

Issue fork gtm_datalayer-3363278

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3363278-drupal-10-compatibility changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

29 May 2023 at 08:07

yogeshsevak created an issue. See original summary.

Comment #2

yogeshsevak commented 29 May 2023 at 08:09

Status:

Active

» Needs review

Status	File	Size
new	gtm-datalayer-d10-compatibility-3363278-2.patch	4.64 KB

Providing patch with fixes. Please review.

Comment #3

29 May 2023 at 08:38

dineshkumarbollu made their first commit to this issue’s fork.

Comment #4

dineshkumarbollu commented 29 May 2023 at 08:43

Status	File	Size
new	Screenshot from 2023-05-29 14-12-31.png	20.13 KB

The patch #2 applied cleanly and doesn't show any D10 compatible issues,
I am attaching Screenshot of D10 upgarde status report

thanks

Comment #5

29 May 2023 at 08:45

dineshkumarbollu opened merge request !1

Comment #6

dineshkumarbollu commented 29 May 2023 at 08:45

Status:

Needs review

» Reviewed & tested by the community

Comment #7

jmaties commented 26 March 2024 at 07:17

Status	File	Size
new	gtm-datalayer-d10-compatibility-3363278-7.patch	595 bytes

PHP Fatal error: Declaration of Drupal\gtm_datalayer_override\Routing\RouteSubscriber::getSubscribedEvents() must be compatible with Drupal\Core\Routing\RouteSubscriberBase::getSubscribedEvents()