When using the vertical Gin toolbar the environment indicator is very subtle. There is a narrow strip of colour down the left side of the toolbar, and the drupal icon changes to the environment colour. Adding an additional colour indicator to the link in the secondary toolbar would improve visibility, and shouldn't detract from Gin's nice design if you choose complementary colours for your environments.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | bottom-border-radius-after.png | 2.51 KB | metalbote |
| #10 | bottom-border-radius-not-nice_hoverd.png | 6.47 KB | metalbote |
| #10 | bottom-border-radius-not-nice.png | 2.44 KB | metalbote |
| #6 | gin-env-indicator-vertical-toolbar.png | 16.88 KB | peacog |
| #5 | gin_enviroment_indicator_CURRENT_style.png | 9.39 KB | thomas.frobieter |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
peacog commentedThe MR adds the proposed change. It looks like this:
Wide screens
Narrow screens
Comment #4
thomas.frobieterI think the style has changed in meantime?
I'd suggest to preserve the great design, something like this:
Comment #5
thomas.frobieterOh, lol. Didn't noticed, this is already the exact implementation. We just switched to the modern Gin bar.
So @Peacog, what do you think? Can we close this?
Comment #6
peacog commentedHi @thomas.frobieter. The patch is to improve visibility when you're using the sidebar, vertical toolbar. With the vertical toolbar the indicator color strip is down the left side of the screen, not across the top. It looks like this (without the patch)
It doesn't stand out much and is easy to miss on a busy screen.
Comment #7
thomas.frobieterTrue, so lets colorize the menu item like suggested! I'll update the issue fork.
Comment #8
thomas.frobieterBlocked by #3388814: Fix GIN Admin Toolbar Style: Secondary toolbar is overlapped by the 3px of the indicators border-top - this needs to be merged to DEV first.
Comment #9
damienmckennaThe other issue was committed, so this work can continue now.
Comment #10
metalboteI stumbled across the following small flaw with the bottom border radius, my commit fixes it.
Current:
After:
Hovered version, and within will be same as before.
Comment #11
trackleft2Please check out the refactoring of how libraries add style for the environment indicator in #3467210: Update module to use CSS variables instead of adding inline CSS via Javascript., and possibly review that MR. Any changes here, will also need to be done there.
Comment #14
trackleft2Comment #17
trackleft2This fix has been rolled into #3467210: Update module to use CSS variables instead of adding inline CSS via Javascript. which has been merged into the 4.x branch and is soon to be released as part of 4.1.0-alpha1 and this release plan #3468997: [META] Release Plan for Environment Indicator Minor (feature) Release 4.1.0.
I've updated !127 with the latest version of 4.x (4.x includes the improvements discussed here in this issue).
Additionally I've moved credit for this issue over to #3467210: Update module to use CSS variables instead of adding inline CSS via Javascript. and created a tugboat build on this issue for easier review. Tugboat builds expire after a few days.