Problem/Motivation

When inspecting the default and hover state of a place block button, There is a noticeable white border on the right side of the button. This line should not be present in the design. Need to remove this. (same issue present in Gin theme also - image attached for references).

Steps to reproduce

  1. Drupal 10.1.x and set the claro theme as admin theme
  2. admin/structure/block, click on any place block button
  3. place block dialog box will be open, check the place button issue.

Proposed resolution

modified the border css property : border-inline-end to resoled this.

File : core/themes/claro/css/components/dropbutton.css

.js .dropbutton-action {
    border-inline-end: none;
}
CommentFileSizeAuthor
#16 interdiff.txt1.83 KBlauriii
#16 3362590-16.patch1.64 KBlauriii
#11 BEFORE.png23.99 KBsantosh_verma
#11 AFTER.png35.46 KBsantosh_verma
#11 3362590-11.patch2.38 KBsantosh_verma
#9 3362590_8.patch858 bytesdsandhya
#9 after-remove-border-img.png61.95 KBdsandhya
#9 before-remove-border-imgg.png61.57 KBdsandhya
#6 after.png51.48 KBamietpatial
#2 3362590-2.patch2.42 KBgauravvvv
A white space line is observed within place block button same gin theme.png50.37 KBHarish1688
A white space line is observed within place block button.png62.17 KBHarish1688

Comments

Harish1688 created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3362590-2.patch2.42 KB

I have attached a patch to fix the same. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Needs Review Queue Initiative

Not seeing this issue on latest 10.0 or on 11.x.

Can we confirm the issue is happening on the latest dev branch.

gauravvvv’s picture

gauravvvv commented
Version: 10.0.x-dev » 10.1.x-dev
Issue summary: View changes

This is happening on 10.1.x.

gauravvvv’s picture

gauravvvv commented
Status: Postponed (maintainer needs more info) » Needs review
Parent issue: » #3316627: dropbuttons get weird white line when font size is changed and at at various zoom settings

This is regression bug of #3316627: dropbuttons get weird white line when font size is changed and at at various zoom settings

amietpatial’s picture

amietpatial commented
Status: Needs review » Needs work
StatusFileSize
new after.png51.48 KB

@smustgrav, yes, I can also see this issue on 10.1.0-dev attaching a screenshot for reference.

@Gauravvv applied your patch and it applied cleanly but still, I am able to see that white line on the place block.

Vidushi Mehta’s picture

Vidushi Mehta commented
Status: Needs work » Needs review
StatusFileSize
new rerolled-3362590-7.patch2.38 KB
new white-border.PNG31.58 KB
new removed-white-border-after-patch.PNG16.55 KB

Added a rerolled patch as #2 was not applying on the latest code
Added before and after screenshots for the same

I've checked on 11.x this issue is showing there as well

Status: Needs review » Needs work

The last submitted patch, 7: rerolled-3362590-7.patch, failed testing. View results

dsandhya’s picture

dsandhya commented
StatusFileSize
new before-remove-border-imgg.png61.57 KB
new after-remove-border-img.png61.95 KB
new 3362590_8.patch858 bytes

Added a patch which I removed right side border for "Place Block" button plz check and review

santosh_verma’s picture

santosh_verma commented

I am reviewing the patch #9

santosh_verma’s picture

santosh_verma commented
StatusFileSize
new 3362590-11.patch2.38 KB
new AFTER.png35.46 KB
new BEFORE.png23.99 KB

Hello @smustgrave, I have tested the issue on both versions, 10.1 and 11.x, and issue persists in both of them. I have tried applying both patch #2 and patch #9, but both of them have failed to apply. From my evaluation, it seems that patch #2 is more useful. Therefore, I am re-rolling the patch #2 created on Drupal 11.x.

Before
before

After
after

santosh_verma’s picture

santosh_verma commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Confirmed seeing what #11 is seeing when in the modal.

Patch #11 does resolve this.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: 3362590-11.patch, failed testing. View results

Harish1688’s picture

Harish1688 commented
Status: Needs work » Reviewed & tested by the community

Random failure, restoring the status.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
StatusFileSize
new 3362590-16.patch1.64 KB
new interdiff.txt1.83 KB

Minor clean-up: added the comment back and I'm using border property to avoid having to add an extra declaration.

  • lauriii committed abd27c4c on 11.x 
    Issue #3362590 by Santosh_Verma, lauriii, Gauravvvv, Harish1688,...

  • lauriii committed c8c7c08a on 10.1.x 
    Issue #3362590 by Santosh_Verma, lauriii, Gauravvvv, Harish1688,...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Committed abd27c4 and pushed to 11.x. Thanks! Also cherry-picked to 10.1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.