Agenda items
Standing items
- Who is here
- Any other suggested topics
- Wins / Thanks / Blockers
- Statistics and functionality update. X new bugs created in last two weeks. Y closed by the initiative.
- The bug I would most like to see fixed
- Update on target items from last meeting
- What should be the initiative focus for the next 2 weeks?
Statistics
0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all timezones.
| ambermatz | Amber, Oregon, USA |
| mohit_aghera | Mohit, India :wave: |
| kimb0 | Kim, Sydney :wave: |
| jibran | Jibran, AU: Just saying hi! Not doing anything with the initiative atm :disappointed: |
| amjad1233 | Amjad, Brisbane :wave: |
| Kristen Pol (she/her) | Kristen, Pittsburgh :wave: |
0️⃣ .5️⃣ What sessions are you looking forward to from the Drupalcon schedule
| kimb0 | https://events.drupal.org/pittsburgh2023/session/drupal-core-maintainer-... |
| jibran | That keynote was good! I really liked it this time around. |
| Kristen Pol (she/her) | I wanted to go to the D7 security session but my panel was at the same time… though I got the lowdown from xjm right afterwards ;) |
| Kristen Pol (she/her) | Congrats to the Previous Next team for their Pitchburgh win! |
1️⃣ Agenda: this is the alternate session to the normal administrative meeting. We're going to focus on a sub-system
| larowlan | I arbitrarily chose the configuration entity system |
| larowlan | I will paste 5 - 10 issues we can hopefully triage |
:checkbox: :ladybug: 1️⃣ #2604450: Prevent uuidKey from being overridden in Configuration entities (edited)
| larowlan | there is a patch here from 7.5 years ago |
| larowlan | I doubt it still applies |
| larowlan | going to tag with needs reroll |
| larowlan | going to :checkbox: this as triaged |
| ambermatz | I searched for and didn’t find a dup. |
| larowlan | :raised_hands: |
:checkbox: :bug:2️⃣ #2544708: The `label_display` setting in `type: block_settings` has the wrong config schema type (edited)
| larowlan | this looks still valid |
| mohit_aghera | This seems to valid. I mean, i still see the string data type in core/config/schema/core.data_types.schema.yml line 318I am not quite sure that it is actual bug or so. Because it doesn’t break anythig as such. |
| larowlan | modules like config inspector rely on this data |
| larowlan | I imagine you could get a strict schema validation error too |
| larowlan | I will make it minor and tag then check |
| mohit_aghera | got it, :+1: |
:checkbox: :snail: 3️⃣ #2909093: Catchable fatal error: Argument 2 passed to SelectQuery::fields() (edited)
| larowlan | this feels unlikely |
| larowlan | an entity you want to query would always have a base table right? |
| mohit_aghera | yeah, exactly. |
| mohit_aghera | Also, the code in core itself has been refactored a lot after the issue has reported. |
| larowlan | yeah |
| larowlan | I reckon closed works as designed? |
| mohit_aghera | hold on, that guy has reported for 7.xseems component is incorrect. |
| mohit_aghera | we can close it anyway. |
:checkbox: :beetle: 4️⃣ #2945635: Figure out how to deal with applyDefaultValue on ConfigEntityAdapter (edited)
| ambermatz | Well, you know, it just needs things. Like an issue summary, for one thing. :) They meant to, it looks like. |
| larowlan | sounds like a task too? |
| larowlan | PMNMI? |
| ambermatz | Agree with that. |
| larowlan | you updating or me? |
| ambermatz | Was just going to ask. I can if that works for you! |
| larowlan | thanks, I'll :checkbox: here then |
| ambermatz | Triaged and commented :white_check_mark: |
:checkbox: :ant: 5️⃣ #2994828: Enforced config dependencies override normal dependencies instead of adding to them (edited)
| larowlan | this sounds bad |
| larowlan | checking if code still exists |
| ambermatz | Possible dup #3180588: "Enforced" Dependencies of Optional Configs Overwrite Other Dependencies |
| larowlan | absolutely is |
| larowlan | will close the other one with no patch and credit tstoeckler |
:checkbox: :bee: 6️⃣ #2987978: ConfigEntityStorage::resetCache() does not call ConfigFactory::reset() (edited)
| larowlan | this sounds familiar @kimb0 we were saying this was odd on Friday when debugging that cache thing... |
| larowlan | sounds valid, I wonder if this would have fixed that issue we had kim? |
| ambermatz | Yeah would be great to verify on a recent project |
| larowlan | added some tags |
| kimb0 | yeah possibly? |
:checkbox: :spider: 7️⃣ #2862699: Multiple sorts are broken for config entity queries (\Drupal\Core\Config\Entity\Query\Query) (edited)
| larowlan | still looks valid, will add some tags too |
:checkbox: :cockroach: 8️⃣ #3030949: Config entity label and other fields translation doesn't work on some pages (edited)
| larowlan | the patch is doing things wrong, but it looks legit |
| larowlan | added tags |
| mohit_aghera | We would need a correct test case to reproduce it. I think previous test case failures seems to be from other changes/reasons. I can dig through it. |
| larowlan | yeah the fails seem to indicate a regression |
| larowlan | e.g we shouldn't be loading config with overrides in the UI (.e.g settings.php) |
:butterfly: 9️⃣ #3203918: Config entities should implement TranslatableInterface
| larowlan | related to 8️⃣ |
| larowlan | This is a hard problem I think |
@larowlan When we validate an issue, which branch/tag is best to spin up? 11.x? Or 10.1.0-beta1? (If we’re trying to validate on the latest version of Drupal?)
| larowlan | 11.x if you can, but if it requires contrib modules, might need 10.1 because of compat issues |
Participants:
kim.pepper, jibran, Kristen Pol, larowlan, ambermatz, mohit_aghera
Comments
Comment #2
griffynh commentedComment #7
larowlanComment #9
larowlanComment #10
quietone commentedAnd here are the stats.
Comment #11
smustgrave commentedWent into #bugsmash channel for 6/06/2023 and verified all threads were captured. Users who contributed to discussing the issues have been credited