Problem/Motivation

The cookiebot declaration javascript is not closed in the templates/cookiebot-declaration.html.twig file is not closed which results in broken HTML.

Steps to reproduce

  • Configure the node where the Cookiebot declaration should be shown.
  • Open the node in a browser.
  • View source.

The script tag is not closed (see after data-culture="en"):

Proposed resolution

Fix the template.

CommentFileSizeAuthor
#4 fix-broken-html-tag-15072908-4.patch770 byteszero2one

Comments

zero2one created an issue. See original summary.

zero2one’s picture

zero2one commented
Issue summary: View changes
zero2one’s picture

zero2one commented
Issue summary: View changes
zero2one’s picture

zero2one commented
StatusFileSize
new fix-broken-html-tag-15072908-4.patch770 bytes

Attached patch fixes the broken HTML tag.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Active » Reviewed & tested by the community

Wow, good catch! Thanks

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: fix-broken-html-tag-15072908-4.patch, failed testing. View results

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Needs work » Reviewed & tested by the community

  • BramDriesen committed 54b8139b on 8.x-1.x authored by zero2one 
    Issue #3362070 by zero2one: Cookiebot declaration javascript tag is not...
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Tagged beta 16

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.