This is a follow up to #3362011: Make it possible to set default target module machine name and path before creating and #3361747: Add test trait to create randomly named, non-conflicting default target modules to refactor/adapt DefaultTargetModuleTest to make use of both the new parameters added to TargetModuleCollection::ensureDefaultTargetModuleIsSet() and the new test trait to avoid naming collisions with any existing default target module.
Look, I'm tired and it's late and you're smart enough.
I'll make a fork and merge request hang tight.
Do the thing.
None.
None.
None.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !26
Comments
Comment #3
ambient.impactComment #4
star-szrWe are planning to remove the method that #3362011: Make it possible to set default target module machine name and path before creating updates, and aren't adopting #3361747: Add test trait to create randomly named, non-conflicting default target modules, so I'm going to close this as outdated.
The larger goal is #3557749: Prompt the user to create a new target module if none are found from a UI/UX perspective.
We are also working on making our tests more robust in terms of not making unnecessary changes to the filesystem (leaving git in a dirty state, specifically).