Problem/Motivation

On the url alias admin UI (/admin/config/search/path) it displays the system path in the anchor text, but then the link itself is to the alias. This creates two issues:

  1. The two adjacent columns claim to be two different thngs and show different anchor text but are in fact identical link urls.
  2. It makes it difficult to see if following the system path actually takes you to the alias (harder to detect if there is some other alias or redirect at play. (makes debugging more difficult)

Steps to reproduce

Proposed resolution

This was originally presented as a solution as part of #3351638: Remove truncation of path alias but was split into the separate issue here.

The href for the system path is not actually a system path, but an alias. It should be replaced with the actual system path as the link so that it matches the link text.

Remaining tasks

User interface changes

The href for the system path is not actually a system path, but an alias. It should be replaced with the actual system path as the link so that it matches the link text.

Screencapture showing system path as the href

API changes

None

Data model changes

None

Release notes snippet

Issue fork drupal-3362007

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

swirt created an issue. See original summary.

swirt’s picture

Issue summary: View changes

swirt’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new265.25 KB

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

shashank5563’s picture

StatusFileSize
new136.86 KB

I have applied the patch on local and found it working as expected.

RTBC.

dineshkumarbollu’s picture

StatusFileSize
new78.39 KB
new81.8 KB

Hi
I Test the MR, and attaching how it looks before and after MR

thanks

swirt’s picture

This change was presented at the #3350284: Drupal Usability Meeting 2023-04-07 UX review call when it was part of #3351638: Remove truncation of path alias I am not certain if it needs to go through that process again or not.

smustgrave’s picture

Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs tests

Can we add a simple assertion somewhere that the paths equal.

swirt’s picture

Good suggestion. I am a bit swamped at the moment. I can circle back to this in a few weeks, or if anyone else has capacity before I get to it, they can add the testing.

rpayanm made their first commit to this issue’s fork.

rpayanm’s picture

Status: Needs work » Needs review

Please review.

swirt’s picture

Status: Needs review » Reviewed & tested by the community

Cheers, rpayanm thank you for such a rapid addition of tests to the patch. Tests look solid and they are passing.

lauriii made their first commit to this issue’s fork.

  • lauriii committed 894c1181 on 11.x
    Issue #3362007 by swirt, rpayanm: Make system path column more accurate
    
lauriii’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs tests

Committed 894c118 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.