Problem/Motivation

In #3123832: [META] Fix @todo items referencing closed issues we've discovered there's a @todo in core/themes/olivero/templates/datetime-wrapper.html.twig.
This @todo is linked to an d.o. issue that is already closed: #3010558: Unnecessary <strong> element in Umami's form-element template may produce invalid markup.

This is the @todo:

/**
 * @file
 * Theme override of a datetime form wrapper.
 *
 * @todo Refactor when https://www.drupal.org/node/3010558 is fixed.
 *
 * @see template_preprocess_form_element()
 */

Proposed resolution

#301055: Problem with the login module was closed as a fixed.
It removed a hardcoded <strong> tag from the error messages and replaced it with a CSS-rule.

Since core/themes/olivero/templates/datetime-wrapper.html.twig doesn't have this hardcoded <strong> tag, there's no need for refactoring.

Let's remove the now outdated @todo and move on to bigger, better and less trivial things.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3361623

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
Title: Remove outdated @todo n datetime-wrapper.html.twig pointing to #3010558 » Remove outdated @todo in datetime-wrapper.html.twig pointing to #3010558
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Title: Remove outdated @todo in datetime-wrapper.html.twig pointing to #3010558 » Remove outdated @todo in Olivero's datetime-wrapper.html.twig pointing to #3010558

Spokje opened merge request !4020

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

LGTM!

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

Beside a rebase which is needed to merge this, this looks straight forward to me 😁

  • quietone committed e8e28995 on 11.x 
    Issue #3361623 by Spokje, smustgrave: Remove outdated @todo in Olivero's...
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Fixed

I read the issue, comments and the related closed issue. The closed issue changes umami templates so it took me a moment to understand why this is being removed from an olivero template. And to confirm that by reading the olivero template.

Committed e8e2899 and pushed to 11.x. Thanks!

Spokje closed merge request !4020

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.