Closed (fixed)
Project:
Configuration Inspector
Version:
2.1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 May 2023 at 16:00 UTC
Updated:
6 Jun 2023 at 07:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leersComment #3
wim leersComment #4
andypostmaybe drush can decorate the service with memoryCache and always skip this keys on get()
Comment #5
gábor hojtsy@andypost: I think its fine if we remove them from cache here, its a developer tool after all, so its more likely that you are tweaking the schema anyway, so it may be helpful in itself that it removes the schema cahes for the respective items?
Comment #6
gábor hojtsyRerolled the patch against the current codebase. Does this only affect Drush?
Comment #7
wim leers#5: my thoughts exactly.
Yes.
People using the Config Inspector UI would then indeed still get potentially stale information. But people may be using Config Inspector just to explore the values in their configuration. That's less likely in the Drush command.
So I figured that it would be potentially disruptive to do it also in the UI.
But … happy to change that. I have no strong opinion.
Comment #8
andypostbtw Drush using own kernel additionally to core's one, but I totally agree that current delete is nice workaround without extra complexity
For UI part we can add a description or even hook_help for route with description pointing to performance settings page where caches can be cleared
Comment #9
andypostIt can be just a description for the checkbox (show only errors) at the top of list
Comment #10
wim leersThat sounds reasonable to me. Note that we could even show when the config schema was constructed & cached, based on the
createdcolumn for the relevant row in thecache_discoverytable! 🤓Comment #11
gábor hojtsyHm is cache clearing a concern on the UI because it would do too much clearing or be detrimental to performance of the tool? I would prefer consistency in how the two interfaces to the module work, otherwise you would get different results on the UI and in Drush, that could quickly get confusing.
Comment #12
wim leersThis.
Not this. Config Inspector itself still does the same exact amount of work either way.
WFM!
Comment #13
wim leersDone.
Comment #14
gábor hojtsyRetitle for the more general solution arrived at.
Comment #16
gábor hojtsyThanks both!
Comment #17
wim leersYay! 🥳