Problem/Motivation

  1. The default [rrssb:image] token doesn't pick up image files
  2. The [rrssbsite:logo-url] returns the site base URL if there isn't a logo
  3. The code is over-complicated due to calling Token::replace()

Proposed resolution

  1. Change the default from [node:field_image:url]|[rrssbsite:logo-url] to [node:field_image:entity:url]|[rrssbsite:logo-url]
  2. Detect empty logo string
  3. Simplify the code by using Token::replacePlain()

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 rrssb.token_.3361095-2.patch2.92 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new rrssb.token_.3361095-2.patch2.92 KB

  • AdamPS committed d69086f5 on 8.x-2.x 
    Issue #3361095 by AdamPS: Fixes to token replacement
adamps’s picture

adamps commented
Status: Needs review » Fixed
adamps’s picture

adamps commented

Second commit fixes the core_version_requirement: Token::replacePlain() was introduced in D9.4.

  • AdamPS committed 78de6393 on 8.x-2.x 
    Issue #3361095 by AdamPS: Fixes to token replacement (part 2)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.