Problem/Motivation

As I found out in #3360782: Exclude fast_404 paths and file extensions by default (Performance), the settings form fields #maxlength of 128 inherited from core due to this issue: is too short.

Especially for the "Extensions to abort search" field, you can't even enter all the required typical file extension values. But we should remove the limit for all relevant fields.

Steps to reproduce

Try entering values with > 128 characters into the "Extensions to abort search" field and save. They are cut off.

Proposed resolution

Remove the #maxlength as config has no limits for such values.
#3331028: Increase default textfield #maxlength=128 to 256 will presumably not be solved soon.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork search404-3360909

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Settings form fieldsets #maxlength limit=128 (from core) is too low » Settings form fields #maxlength limit=128 (from core) is too low
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Active » Needs review

As unsetting the #maxlength would be worse to read and 512 characters will presumably enough forever, let's increase the value to 512 instead. Once the referenced core issue is solved, this can be removed.

Anybody opened merge request !10

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Settings form fields #maxlength limit=128 (from core) is too low » Settings form fields #maxlength limit=128 (from core) is too short
grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

LGTM! Are you sure, that the comment is necessary there?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Are you sure, that the comment is necessary there?

I'd say so, because you wouldn't add the limit at all if the core issue wouldn't exist. A reference makes sense so, I think.

emilymathew’s picture

emilymathew commented

  • emilymathew committed 4e373357 on 2.x 
    Issue #3360909 by Anybody, Grevil, emilymathew: Settings form fields #...
emilymathew’s picture

emilymathew commented
Status: Reviewed & tested by the community » Fixed
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thank you @emilymathew! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.