Problem/Motivation

Buddy Coder issue for core's coding standards issue #3360160: Stop using FQCN in PHPDoc annotations.

Steps to reproduce

Proposed resolution

Postponed on #3360160: Stop using FQCN in PHPDoc annotations

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork coder-3360163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Postponed
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Version: 8.3.x-dev » 9.x-dev
Status: Postponed » Active

I think we can already start work on this to drop the relevant Slevomat sniff from Coder.

Looks like there was no disagreement posted on the Coding standards issue.

klausi opened merge request !35

  • klausi committed 233fbd8d on 9.x 
    feat(FullyQualifiedClassNameInAnnotation): Remove sniff to allow not...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Fixed

Implemented with vibe coding via Github Copilot AI with prompt on the test file "This test should be removed to the good test folder and the fixed file removed. We are changing the coding standards check to allow data type annotations in comments that are not fully namespaced. Make the modifications and adapt the test cases."

That worked well, only had to adapt the code comments manually in the test case.

Also updated the API changes in #3552621: Release new Coder 9 major upgrade.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.