The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Enable automated testing for tac_lite. It would be best to at least write a stub test but even if there is not that, enabling testing will test if a site can build with the module.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | tac_lite-tests-3359803-2.patch | 1.01 KB | liam morland |
Issue fork tac_lite-3359803
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
liam morlandHere is a simple functional test to get started.
Comment #4
liam morlandThis merge request enables testing, creates a simple test to get started, and fixes all coding standards issues except #3395316: Use dependency injection. Doing this required also fixing #3359802: Add schema for tac_lite.settings.
Comment #5
damienmckennaYes yes!
Comment #6
damienmckennaAm going to expand upon this and merge in #3359802: Add schema for tac_lite.settings.
Comment #7
damienmckennaI'll continue working on this on Monday, I want to add test coverage to confirm the permission system actually locks down the content as expected.
Comment #8
liam morlandI was thinking this issue would just be about getting testing to run. There can be a follow-up about writing comprehensive tests. If something is running, at least there can be coding standards checks for all changes.
Comment #9
damienmckennaWhile we're waiting for the maintainers to follow up on issues there's no harm on improving what you'd built to both fix the schema and cover usage scenarios. Also, I needed to make sure there was test coverage for this functionality for a work project, so rather than building something custom for our site I'm extending your MR to make the test coverage useful for everyone.
Comment #10
damienmckennaComment #11
damienmckennaNow we have some test coverage for the basic module functionality, it can be refined some more if needed.
Comment #12
liam morlandI made a couple of minor changes. All tests and checks are passing except dependency injection, which is handled in #3395316: Use dependency injection.
Comment #13
damienmckennaThanks Liam.
Maintainers: it would be really helpful if you could commit this, it would open the door for us to add test coverage for other scenarios and issues. Thank you.
Comment #14
damienmckennaBTW I split out the setup() method into a separate base class so that I can reuse some of the logic in #3583524: Add support for Paragraphs entities.
Comment #15
damienmckennaWe'll also need to consider when to replace node_access_rebuild() with the new API: https://www.drupal.org/node/3534610
Comment #16
damienmckennaThis is a great improvement for the codebase.