Problem/Motivation

When Features UI is enabled and Claro is the admin theme (default admin theme now), the details element dropdowns look misaligned.

Steps to reproduce

  1. Enable Features UI module
  2. Set Claro as default admin theme
  3. Navigate to admin/config/development/features

Current state of Features UI

Proposed resolution

Increase the selector specificity to exclude Claro details elements from the styles in features_ui.admin.css.
This will then inherit the default Claro styles for the details element.
Proposed Resolution for Features UI

User interface changes

As above, this reverts to using the default Claro styles for <details> elements.

CommentFileSizeAuthor
Proposed resolution.png66.39 KBpsebborn
Current state.png59.92 KBpsebborn

Issue fork features-3359698

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

psebborn created an issue. See original summary.

psebborn opened merge request !24

psebborn’s picture

psebborn commented
Status: Active » Needs review

Created a merge request to fix this issue: for all themes except Claro the styles will be applied but for Claro it's left with the theme defaults.

psebborn’s picture

psebborn commented
Assigned: psebborn » Unassigned
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Related issues: +#3068461: Make Features UI theme-agnostic

Thanks for noting the issue. Related: #3068461: Make Features UI theme-agnostic. I wonder if the rules that are breaking in Claro are more leftovers from Seven that now can safely be removed instead of adding exclusions.

psebborn’s picture

psebborn commented

I would probably agree with that; as Claro's now the default admin theme it displays fine if those styles are removed. I left them in so as to keep support for Seven but perhaps that's an issue for Seven rather than Features UI?
Happy to update the merge request and remove them if that is the most appropriate course?

psebborn’s picture

psebborn commented

Updated the Merge Request now, removing those unnecessary styles as discussed

Dave Reid opened merge request !30

Dave Reid closed merge request !30

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Version: 8.x-3.12 » 8.x-3.x-dev
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

I tested this out locally and confirmed it resolved the issue for me.

matthand made their first commit to this issue’s fork.

  • matthand committed 41760662 on 5.0.x authored by psebborn 
    Issue #3359698 by psebborn: Fixed display of details element when using...
matthand’s picture

matthand
he/him
Primary language English
Location Maryland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for reviewing and testing community. This change looks ready to merge into 3.x-dev branch. Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.