Problem/Motivation

@mglaman released version 1.1.32 of mglaman/phpstan-drupal (See https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.32)
Looking at https://www.drupal.org/node/3060/qa it removes some false positives on Level 1.
It also introduces some new suppressions in \Drupal\KernelTests\Core\Datetime\DatelistElementFormTest that need to be looked at and determined if they need a fix in Drupal Core or are regressions and should be fixed upstream. This is for a separate issue.
EDIT: They need to be fixed upstream, see https://github.com/mglaman/phpstan-drupal/issues/553.

Steps to reproduce

See https://www.drupal.org/node/3060/qa and notice the failures on both updated deps jobs for 10.0.x and 10.1.x

Proposed resolution

- Upgrade mglaman/phpstan-drupal
- Create a new baseline
- Bump version of mglaman/phpstan-drupal in composer.json to 1.1.32, since the newly created baseline won't pass on any version below that.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3359543-10.0.x-3.patch7.69 KBspokje

Issue fork drupal-3359543

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !3979

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 3359543-10.0.x-3.patch7.69 KB
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

The patch in #3 fixes exactly what is described in the IS, we should create the followups before committing this, but the patch looks great.

spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented
Issue summary: View changes
spokje’s picture

spokje
Primary language Dutch
commented

Thanks @borrison, I've opened upstream issue https://github.com/mglaman/phpstan-drupal/issues/553 to deal with the false positives in the two DateTime tests.

  • catch committed afa6dc6a on 10.1.x 
    Issue #3359543 by Spokje: Update mglaman/phpstan-drupal and make daily "...

  • catch committed 51021373 on 11.x 
    Issue #3359543 by Spokje: Update mglaman/phpstan-drupal and make daily "...

  • catch committed a1c04a39 on 10.0.x 
    Issue #3359543 by Spokje: Update mglaman/phpstan-drupal and make daily "...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/cherry-picked to 11.x/10.1.x/10.0.x respectively. Four steps forwards three steps back :)

Spokje closed merge request !3979

spokje’s picture

spokje
Primary language Dutch
commented

Four steps forwards three steps back :)

I see it in a more positive way: It's like running into a brick wall, yet every time slightly slower...

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

I opened https://github.com/mglaman/phpstan-drupal/issues/418 for myself.

I think I'll implement it as a release gate check to see what changes will affect Drupal core before I make a release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.