Problem/Motivation

Add route name instead of the url

Steps to reproduce

Proposed resolution

configure: admin/config/system/walkme
into
configure: walkme.walkme_form

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#7 Removeunnecessarylinesfrominfo-3359156-7.patch325 bytesnishant

Issue fork walkme-3359156

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Nishant created an issue. See original summary.

nishant’s picture

nishant
Primary language English
commented

I am working on this.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Remove unneseray line from info.yml » Remove unnecessary lines from info.yml
Category: Bug report » Task
Status: Active » Needs work
Issue tags: +Needs issue summary update

The issue summary should always describe what should be fixed/changed. The title is not sufficient to describe what the issue is, even in the case a patch is provided.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Since the content of the walkme.info.yml file is the following, it is not clear which lines should be unnecessary.

name: WalkMe Integration
type: module
description: 'Very basic module for implementing WalkMe™ within Drupal.'
core_version_requirement: ^8 || ^9 || ^10
package: WalkMe
configure: admin/config/system/walkme

Nishant opened merge request !2

nishant’s picture

nishant
Primary language English
commented

@apaderno,

This line is not required in info.yml 'admin/config/system/walkme'

nishant’s picture

nishant
Primary language English
commented
StatusFileSize
new Removeunnecessarylinesfrominfo-3359156-7.patch325 bytes

Created Patch and MR, Please review

nishant’s picture

nishant
Primary language English
commented
Issue summary: View changes
nishant’s picture

nishant
Primary language English
commented
Assigned: nishant » Unassigned
Status: Needs work » Needs review
shiv_sharma’s picture

shiv_sharma commented
Status: Needs review » Needs work

@nishant
arrtibutes are correct issue is we are using URL as value.
configure: admin/config/system/walkme
It should be routename
configure: walkme.walkme_form

shashank5563’s picture

shashank5563 commented

@nishant, Please see the .info.yml file documentation.

https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-abo...

shashank5563’s picture

shashank5563 commented
Title: Remove unnecessary lines from info.yml » Add rout name instead of url from info.yml for configure
Issue summary: View changes
shashank5563’s picture

shashank5563 commented
Title: Add rout name instead of url from info.yml for configure » Add route name instead of url from info.yml for configure

Nishant opened merge request !3

Nishant closed merge request !2

nishant’s picture

nishant
Primary language English
commented
Status: Needs work » Needs review

Updated MR, Please review.

shashank5563’s picture

shashank5563 commented
Title: Add route name instead of url from info.yml for configure » Add route name instead of url in info.yml for configure
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Issue tags: -Needs issue summary update

kpoornima made their first commit to this issue’s fork.

kpoornima’s picture

kpoornima commented
Status: Needs review » Fixed

Thanks All

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.