In the prototype testing of GitLabCI the PHPCS job overwrites Scheduler's phpcs.xml.dist file with its own. This results in Scheduler's customised rules being ignored, and we get warnings about standards that we are not interested in, or for those where we have modified the arguments, eg to allow longer array definition line length.

According to Moshe on #3357870: The PHPCS job overwrites the projects own phpcs.xml.dist file contrib modules should use a phpcs.xml file not a phpcs.xml.dist version.

Issue fork scheduler-3358806

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Related issues: +#3357870: The PHPCS job overwrites the projects own phpcs.xml.dist file

First the MR with no change to show the baseline current state of the jobs.

jonathan1055 opened merge request !86

jonathan1055’s picture

jonathan1055 commented

Baseline phpcs job https://git.drupalcode.org/project/scheduler/-/jobs/46080 shows the current failures
Also images stored on #3357870: The PHPCS job overwrites the projects own phpcs.xml.dist file

jonathan1055’s picture

jonathan1055 commented

The Gitlab pipeline PHPCS job for the branch is https://git.drupalcode.org/project/scheduler/-/jobs/46080
It fails on two sniffs, with errors

 284 | WARNING | [x] There must be no blank line following an inline
     |         |     comment (Drupal.Commenting.InlineComment.SpacingAfter)

and

 873 | ERROR   | [ ] The array declaration extends to column 91 (the limit is
      |         |     80). The array content should be split up over multiple
      |         |     lines (Drupal.Arrays.Array.LongLineDeclaration)
jonathan1055’s picture

jonathan1055 commented

The PHPCS job for this MR is https://git.drupalcode.org/project/scheduler/-/jobs/46086 and it passes

jonathan1055’s picture

jonathan1055 commented

Test failures are unrelated to this issue. See #3358927: SchedulerRulesEventsTest fail with "Indirect modification of overloaded property ... has no effect"

  • jonathan1055 committed b8ca0c1b on 2.x 
    Issue #3358806 by jonathan1055: Rename phpcs.xml.dist to phpcs.xml in...
jonathan1055’s picture

jonathan1055 commented
Status: Active » Fixed
Parent issue: » #3356800: Enable GitLab CI testing

Renaming should not cause a big problem. Better to do this now before 2.0 release
Will also backport to 8.x-1.x to keep both branches aligned.

  • jonathan1055 committed 389244d2 on 8.x-1.x 
    Issue #3358806 by jonathan1055: Rename phpcs.xml.dist to phpcs.xml in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.