Problem/Motivation

iCalendar files may have fields in addition to the standard fields. For example an entry from Google Calendar might look like

BEGIN:VEVENT
DTSTART:20111218T093000Z
DTEND:20111218T103000Z
DTSTAMP:20230507T165416Z
UID:l3q7rouf2nl87c4rtblhtg7umg@google.com
CREATED:20110917T142159Z
DESCRIPTION:
LAST-MODIFIED:20230126T222311Z
LOCATION:
SEQUENCE:1
STATUS:CONFIRMED
SUMMARY:Öffentliches Blasen
TRANSP:OPAQUE
CATEGORIES:Posaunenchor
END:VEVENT

Not all of these fields are supported and the unsupported fields cannot be referenced.

Steps to reproduce

Create a feed from a google calendar.

Proposed resolution

  • Implement all fields for all major calendar providers: iCal, Google Calendar, OWA, Nextcloud etc.
  • Allow to define additional calendar fields.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 ics-parser-private-properties-3358713-3.patch1.19 KBkarlshea

Issue fork feeds_ical-3358713

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

keinstein created an issue. See original summary.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

This used to work, but ics-parser moved any custom properties to a private $additionalProperties array, making it impossible to get that data into the Feeds data transfer object.

See https://github.com/u01jmg3/ics-parser/issues/318 and https://github.com/u01jmg3/ics-parser/issues/329

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Version: 2.0.4 » 2.1.0
Status: Active » Needs review
StatusFileSize
new ics-parser-private-properties-3358713-3.patch1.19 KB

Patch attached that uses reflection, it's not a great solution but it's working for me.

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

Property visibility fixed in https://github.com/u01jmg3/ics-parser/issues/329.

The patch could be changed to not use reflection, but it would require the patched version of ics-parser (whenever it's released) to be installed.

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Assigned: Unassigned » ben.hamelin

@KarlShea - looks like we got that release in 3.4.0
https://github.com/u01jmg3/ics-parser/releases/tag/v3.4.0

We could plan to up the requirement here and release this as 2.2.0

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

Sounds great, thanks!

KarlShea opened merge request !8

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

Bumped ics-parser to ^3.4 and removed reflection

  • ben.hamelin committed 7ee3af69 on 2.x-dev authored by KarlShea 
    Resolve #3358713 "Add additional fields"
Increase johngrogg/ics-parser...
ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Status: Needs review » Fixed
ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented

Committed and released with 2.2.0.
Thanks @KarlShea!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.