Problem/Motivation

PHP deprecation notice:

PHP Deprecated:  a:5:{s:11:"deprecation";s:86:"Creation of dynamic property Drupal\Tests\token\Kernel\FieldTest::$field is deprecated";s:5:"class";s:35:"Drupal\Tests\token\Kernel\FieldTest";s:6:"method";s:24:"testTimestampFieldTokens";s:15:"triggering_file";s:100:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/token/tests/src/Kernel/FieldTest.php";s:11:"files_stack";a:6:{i:0;s:100:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/token/tests/src/Kernel/FieldTest.php";i:1;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:2;s:91:"/home/runner/work/acquia_cms/orca-build/vendor/phpunit/phpunit/src/Framework/TestResult.php";i:3;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:4;s:19:"Standard input code";i:5;s:19:"Standard input code";}} in /home/runner/work/acquia_cms/orca-build/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerTrait.php on line 284

PHP Deprecated:  a:5:{s:11:"deprecation";s:87:"Creation of dynamic property Drupal\Tests\token\Kernel\EntityTest::$vocab is deprecated";s:5:"class";s:36:"Drupal\Tests\token\Kernel\EntityTest";s:6:"method";s:18:"testEntityOriginal";s:15:"triggering_file";s:101:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/token/tests/src/Kernel/EntityTest.php";s:11:"files_stack";a:6:{i:0;s:101:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/token/tests/src/Kernel/EntityTest.php";i:1;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:2;s:91:"/home/runner/work/acquia_cms/orca-build/vendor/phpunit/phpunit/src/Framework/TestResult.php";i:3;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:4;s:19:"Standard input code";i:5;s:19:"Standard input code";}} in /home/runner/work/acquia_cms/orca-build/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerTrait.php on line 284

Issue fork token-3358295

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vishalkhode created an issue. See original summary.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212

I will update the PHP deprecation code.

akshaydalvi212 opened merge request !38

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Active » Needs review

Updated the code and raised the MR.
kindly review.

vishalkhode’s picture

vishalkhode commented
Status: Needs review » Needs work

Hi akshaydalvi212
The change made is incorrect. We just need to define the property in class before accessing it.

Rajeshreeputra made their first commit to this issue’s fork.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review
ankitv18’s picture

ankitv18 commented
Version: 8.x-1.11 » 8.x-1.x-dev
Assigned: Unassigned » ankitv18
Status: Needs review » Needs work
rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Issue tags: +ACMS2023
ankitv18’s picture

ankitv18 commented
Assigned: ankitv18 » Unassigned
Status: Needs work » Needs review

Can someone review the MR!38

Note: with Drupal 10.1.x for PHP 8.1 and 8.2 one of the test is failing i.e https://www.drupal.org/pift-ci-job/2668140

Can we log separate ticket to address this issue or do we need to handle in this only?

Berdir made their first commit to this issue’s fork.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Thanks for the cleanup, this looks OK now. Yes, a separate issue for the 10.1 test fail makes sense.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented

@Berdir when can we expect the release for PHP 8.2 and Drupal 10.1 compatible release.