Problem/Motivation

We have 14 errors on test cases for multiple modules, besides some code standard issues, we need to fix this before going for a new stable release on Drupal 10

PHP Fatal error: Declaration of Drupal\ldap_servers_dummy\FakeQuery::execute() must be compatible with Symfony\Component\Ldap\Adapter\QueryInterface::execute(): Symfony\Component\Ldap\Adapter\CollectionInterface in /var/www/html/modules/contrib/ldap/ldap_servers/tests/modules/ldap_servers_dummy/src/FakeQuery.php on line 31

Tests: 45, Assertions: 174, Errors: 14.

Steps to reproduce

Install the module on dev branch
Run the PHPUnit for the LDAP module

Proposed resolution

Update compatible methods on interfaces using symfony/ldap 6.x

Issue fork ldap-3358276

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sergiogsanchez created an issue. See original summary.

sergiogsanchez opened merge request !34

sergiogsanchez’s picture

sergiogsanchez commented
Status: Active » Needs review

MR Added

sergiogsanchez opened merge request !35

sergiogsanchez closed merge request !35

sergiogsanchez’s picture

sergiogsanchez commented

Cleaning MRs

jidrone made their first commit to this issue’s fork.

jidrone’s picture

jidrone commented
Status: Needs review » Reviewed & tested by the community

I passes the test and code looks good.

  • sergiogsanchez committed 47b8b236 on 8.x-4.x 
    Issue #3358276 by sergiogsanchez, jidrone: Automated testing symfony/...
sergiogsanchez’s picture

sergiogsanchez commented
Status: Reviewed & tested by the community » Fixed
sergiogsanchez’s picture

sergiogsanchez commented
Status: Fixed » Closed (fixed)
bluegeek9’s picture

bluegeek9 commented
Assigned: sergiogsanchez » Unassigned