Closed (won't fix)
Project:
Drupal core
Version:
10.1.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Apr 2023 at 08:01 UTC
Updated:
28 Apr 2023 at 16:43 UTC
Jump to comment: Most recent
Comments
Comment #2
larowlanComment #3
larowlanComment #4
jonathanshawIn #2903456: Allow kernel tests to fail or expect logged errors (https://git.drupalcode.org/project/drupal/-/merge_requests/14) we created an AssertableLogger that is much more sophisticated than either colinodell/testlogger or Symfony's BufferingLogger. The idea with colinodell/testlogger was that we would now extend AssertableLogger from that.
What we need for #2903456: Allow kernel tests to fail or expect logged errors is so far beyond the capabilities of BufferingLogger (which offers so little code itself) that I doubt the complexity of adding BufferingLogger as a dependency is worth it. Honestly, I thought it was debatable whether colinodell/testlogger was worth it.
Additionally, as I understand it BufferingLogger basically temporarily stores logs and then flushes them on at the end of a request:
I find it hard to forsee the consequences of this behavior change for test DX.
Comment #5
larowlanDiscussed with catch and lauriii
We agree that the DX doesn't justify it