Problem/Motivation

❯ phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

FILE: /Users/specbee/Sites/Projects/url_restriction_by_role/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
 14 | WARNING | Line exceeds 80 characters; contains 95 characters
 15 | WARNING | Line exceeds 80 characters; contains 88 characters
 51 | WARNING | Line exceeds 80 characters; contains 118 characters
 52 | WARNING | Line exceeds 80 characters; contains 131 characters
 53 | WARNING | Line exceeds 80 characters; contains 213 characters
 54 | WARNING | Line exceeds 80 characters; contains 140 characters
----------------------------------------------------------------------

Time: 156ms; Memory: 10MB

Steps to reproduce

Run following command
phpcs --standard=“Drupal,DrupalPractice” --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

CommentFileSizeAuthor
#3 3356808-After-Patch.png42.87 KBclarkssquared
#3 3356808-Applying-The-Patch.png58.67 KBclarkssquared
#3 3356808-Before.png137.25 KBclarkssquared
#2 codingstandards-3356808-2.patch1.89 KBdineshkumarbollu

Comments

dineshkumarbollu created an issue. See original summary.

dineshkumarbollu’s picture

dineshkumarbollu commented
Assigned: dineshkumarbollu » Unassigned
Status: Active » Needs review
StatusFileSize
new codingstandards-3356808-2.patch1.89 KB
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3356808-Before.png137.25 KB
new 3356808-Applying-The-Patch.png58.67 KB
new 3356808-After-Patch.png42.87 KB

Hi dineshkumarbollu

I applied your patch #2 to the URL Restriction By Role module version 1.1.x-dev and verified that the PHPCS issues were fixed.

Please look at the screenshot attached as your reference.

Thank you.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

imustakim’s picture

imustakim commented
Issue summary: View changes
Status: Needs work » Needs review

Issue summary updated.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor
Issue tags: -Needs issue summary update
dmcosta’s picture

dmcosta commented

Thank you everyone. Patch committed to the dev branch.

dmcosta’s picture

dmcosta commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.