Something I've encountered over several versions of Drupal is this HORRIBLE color combination in the Block Layout example screen. I've mentioned this before, and someone said they thought this was a theme-specific issue, but I have seen this in basically every theme I've used, so I'm pretty sure this must relate back to Core. This White text on the Yellow background is completely non-readable. (see attached example).
'block-region' doesn't have color property. It was using inherited color property of border. But at certain places, it was overridden by 'footer'. That is color: white; and the text is not visible.
Add color: #000; property to 'block-region'. So it doesn't get overridden and stay visible.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Screenshot 2023-05-05 at 10.17.28 AM.png | 99.5 KB | gauravvvv |
| #3 | 3356372-3.patch | 762 bytes | gauravvvv |
| #2 | Screen Shot 2023-04-25 at 1.39.59 PM.png | 57.95 KB | begrafx |
| #2 | Screen Shot 2023-04-25 at 1.39.01 PM.png | 38.69 KB | begrafx |
| #2 | Screen Shot 2023-04-25 at 1.38.14 PM.png | 17.26 KB | begrafx |
Comments
Comment #2
begrafx commentedLooking at this same screen using various themes, it is strange, because it is not happening on EVERY theme... for example, Oliverio does just fine. However there are some that end up as a mix, some of the titles being black while others are still white. I've screenshot a few examples. I'm also noticing the absence of the "exit" button/tab to get out of this screen.
Comment #3
gauravvvv commentedThat was happening because the 'block-region' doesn't have color property. It was using inherited color property of border. But at certain places, it was overridden by 'footer'. Now I have added color to block-region and attached the patch for same. please review
Comment #4
smustgrave commentedIssue summary should be updated with before/after screenshots as well as proposed solution.
Comment #5
gauravvvv commentedUpdated issue summary and added before/after screenshots.
Comment #6
smustgrave commentedChange looks good thanks for the screenshots!
Comment #8
smustgrave commentedUnrelated failure.
Comment #11
longwaveI have run into this before on client sites and it's an obvious bug but was never frustrated enough to raise the issue or fix it.
Confirmed that this only affects the
drupal.block.adminlibrary which is only used in admin specific circumstances. To me this is OK to change in stable9 given it's an admin-facing-only bug and also to backport to 10.1.x given the impact is minimal.Committed and pushed ee81893874 to 11.x and 0b988786b5 to 10.1.x. Thanks!