Problem/Motivation

Background color was added to dropbuttons in Claro.
https://www.drupal.org/project/drupal/issues/3316627

Now the dropbuttons are ugly. See attached screenshots.

light
dark

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 after patch 3355885 applied.png101.02 KBHarish1688
#5 after patch apled 3316627-44-9.5.x.png254.48 KBHarish1688
#5 3355885.patch1.02 KBHarish1688
#6 3355885-after.png4.77 KBpcate
gin_dropbutton_dark.png2.91 KBpasqualle
#6 3355885-before.png4.86 KBpcate
gin_dropbutton_light.png3.31 KBpasqualle

Comments

Pasqualle created an issue. See original summary.

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented
Title: Dropbutton style is broken » Dropbutton style is ugly
saschaeggi’s picture

saschaeggi
he/him
commented
Title: Dropbutton style is ugly » Dropbutton style issue after Claro update
Harish1688’s picture

Harish1688 commented

Hi @Pasqualle,

Can you please brief the steps to reproduced the issue on local. ? which version of claro theme is used or which number of patch number, you have used (you mention in ticket: 3316627)

Harish1688’s picture

Harish1688 commented
Status: Active » Needs review
StatusFileSize
new 3355885.patch1.02 KB
new after patch apled 3316627-44-9.5.x.png254.48 KB
new after patch 3355885 applied.png101.02 KB

Hi,

After claro theme update by that patch "https://www.drupal.org/files/issues/2023-04-03/3316627-44-9.5.x.patch" i face the drop button theme issue in gin theme.
issue created attached screen: after patch apled 3316627-44-9.5.x.png

for issue : create a patch : 3355885.patch
screen shot after patch (3355885) - after patch 3355885 applied.png
Needs review.

pcate’s picture

pcate commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3355885-before.png4.86 KB
new 3355885-after.png4.77 KB

Saw this same issue after updating to Drupal core v9.5.9. Patch applied cleanly and fixed the issue. Screenshots of before/after attached.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Hi,

I also encountered the problem right now when doing the update on a project.

Core: 9.5.7 -> 9.5.9
Gin: 8.x-3.0-rc2 -> 8.x-3.0-rc3

Patch from comment 5 fixed the issue.

Thanks!

rajab natshah’s picture

rajab natshah
he/him
commented

Facing the same issue.
Thanks for the quick fix patch.
Would this work with other accent colours?
Maybe in many other cases like #3336167: Dropdown button selector on paragraphs is truncated to only 2 items.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks, switched to use transparent to sustain the styling we had in place before.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

gaurav_manerkar’s picture

gaurav_manerkar commented

This problem is still present for dropdowns in dialogs
Created another issue - https://www.drupal.org/project/gin/issues/3423358