GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff_7-10.txt | 1.48 KB | akram khan |
| #10 | 3355535-10.patch | 2.62 KB | akram khan |
| #7 | codingstandards-3355535-7.patch | 2.64 KB | soham sengupta |
| #3 | codingstandards-3355535-2.patch | 2.54 KB | chanderbhushan |
Issue fork markdown_field_formatter-3355535
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3355535-coding-standards
changes, plain diff MR !1
- 3355535-gitlab-ci-reports
changes, plain diff MR !2
Comments
Comment #2
dineshkumarbollu commentedComment #3
chanderbhushan commentedAdded patch for fix coding standards .
Comment #4
raveen_thakur51 commentedI have reviewed patch #2. And it seems as per coding standards. Thank you.
Comment #5
avpadernoComment #6
avpadernoI am reviewing the patch in comment #2.
It is not how parameters are described. For example, there is no need to say that a parameter is... a parameter.
There are two typos.
Comment #7
soham sengupta commentedHi, I have updated the parameter comments.
Comment #8
chanderbhushan commentedIn #3 patch I have fixed.
Comment #9
avpadernoIn English, there are rules about which words are written capitalized. On Entity Type Manager only the first word is correctly spelled.
There is a missing article, in the short description.
It is redundant to say that the
$plugin_idparameter is the plugin_id of the formatter, since that is repeating the parameter name.The correct description for those parameters can be seen in constructors like
PluginBase::__construct(), for example.It is sufficient to say The formatter label.
Any is not necessary.
Entity is misspelled, since it is not at the beginning of the sentence (contrary to The).
Comment #10
akram khanaddressed #9
Comment #11
a.aaronjake commentedHi @Akram Khan,
The patch you provided was applied successfully, but there is a file that has 2 errors reported. Please see below:
Kindly check
Thanks,
Jake
Comment #14
atul_ghate commentedComment #15
a.aaronjake commentedHi @atul_ghate,
The changes you committed on MR !1 was applied not-so successfully, but it fixed all errors.
Will now move this to RTBC
Thanks,
Jake
Comment #17
avpadernoMR !1 fixed all the PHP_CodeSniffer errors/warnings.
Comment #18
avpaderno