Problem/Motivation

TypeError: Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher::dispatch(): Argument #1 ($event) must be of type object, string given ... forward/src/Form/ForwardForm.php on line 591 ... Also on line 614.

Steps to reproduce

Try to forward a node on a Drupal 10 site.

Proposed resolution

Change record:
https://www.drupal.org/node/3159012

Version requirement bump: 9.1^

CommentFileSizeAuthor
#5 forward-event-dispatcher-3355406-5.patch2.16 KBjason_purdy
#4 forward-event-dispatcher-3355406-4.patch2.16 KBjason_purdy
#2 forward-event-dispatcher-3355406-2.patch2.16 KBnathaniel

Issue fork forward-3355406

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Nathaniel created an issue. See original summary.

nathaniel’s picture

nathaniel commented
Status: Active » Needs review
StatusFileSize
new forward-event-dispatcher-3355406-2.patch2.16 KB
jason_purdy’s picture

jason_purdy commented

#2 doesn't apply to the latest version 4.0.2. I'll see if I can make a new one.

jason_purdy’s picture

jason_purdy commented
StatusFileSize
new forward-event-dispatcher-3355406-4.patch2.16 KB

Let's see if this works...

jason_purdy’s picture

jason_purdy commented
StatusFileSize
new forward-event-dispatcher-3355406-5.patch2.16 KB

My previous attempt also did not cleanly patch, because 4.0.2's sub-module for testing didn't have D10 in the core list. Updated to match. Take 2!

g_miric’s picture

g_miric commented
Status: Needs review » Reviewed & tested by the community

Works as expected.

jan kellermann made their first commit to this issue’s fork.

jan kellermann opened merge request !2

jan kellermann’s picture

jan kellermann commented

Works for me. Created MR for only change order in dev-tree.

john.oltman’s picture

john.oltman commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jason_purdy’s picture

jason_purdy commented

Any chance of getting this released in a new 4.0?

dww’s picture

dww
we/he/they
commented

Not sure why it didn't show up here, but FYI, I pushed https://git.drupalcode.org/project/forward/-/commit/4b81d324b220910a5bc7... to bump the minimum core requirements to 9.1.x due to this change breaking compatibility with older versions of core. It was mentioned in the summary, but never included in the patches here.

Cheers,
-Derek