Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The potx info file incorrectly claims ^8 || ^9 || 10 core compatibility.
Since #3285613: Drupal 10 compatibility fixes for potx the new 9.3 extension listing services are used unconditionally.
That issue introduced the services in Drush files only if I'm not mistaken, so the problematic space is limited, but still.
Given that 8.x-1.x only has a green test on Drupal 10.1, and given that it seems that issues are tested on Drupal 9 recent or 10 recent only, it seems a bit too much to ask to try to be compatible with three major versions. It complicates things for contributors. See for example #2641334-22: Drush Support for extracting strings in the theme files.
Steps to reproduce
Proposed resolution
Consider the claim in the 1.0.0 info file a bug and narrow it down. Or at least closer to actual compatibility if there is no data on the actual state of things. ^9.3 || 10 seems like a reasonable improvement. Or perhaps ^9.5 || 10 to be on the safe side.
To then quickly help out users with older Drupal core versions, it seems very doable to tag a 1.0.0-beta1 at the commit just before the commit that introduced D10 compatibility and 9.3 services. That would differ from 1.0.0 only in D10 compatibility changes.
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | potx-comaptibility_issues-3354887.patch | 510 bytes | shreya_th |
Issue fork potx-3354887
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
eric_a commentedComment #3
eric_a commentedComment #4
eric_a commentedComment #5
eric_a commentedComment #6
eric_a commentedComment #7
eric_a commentedOk, things are not that simple.
There are two drush command files. One that is loaded by Drush 8 and older and one that is loaded by Drush 9 and higher.
These Drush versions have their own Drupal core version compatibility.
https://www.drush.org/latest/install/#drupal-compatibility
https://weitzman.github.io/blog/port-to-drush9
Comment #8
eric_a commentedIf you're on Drush 9 or Drush 10 it would appear that you must be running Drupal 8 or Drupal 9 and not 10. If you're on Drush 11 you could still be on Drupal 9.1 or 9.2.
So the command class must be compatible with Drupal 8 and 9.0, 9.1 and 9.2 if the info file claims that the module code is runnable on ^8 || ^9.
Old potx.drush.inc files are only loaded by Drush 8 or lower, so that file must be compatible with Drupal 8. Drush 8 is not compatible with Drupal 9 and higher so no point in trying to handle thoses versions.
Comment #9
watergate commentedI agree that the compatibility claim in the
potx.info.ymlis currently incorrect.If the 8.x-1.x version of this module should still support Drupal 8, and therefore Drush 8, then I would propose creating a 2.x version/branch for this module that supports Drupal core ^9.3 || 10 (and thereby Drush 10 and 11). The 8.x-1.x should be made compatible with Drupal 8 again (this means that the changes made in #3285613: Drupal 10 compatibility fixes for potx should be partially rolled back).
If Drupal 8 support can be dropped in this module's 8.x-1.x version, the proposed commit tag would be a friendly gesture. To prevent confusion, the
potx.drush.incshould be removed since only Drush 10 or higher should be supported.Comment #10
shreya_th commentedI have made changes in info.yml for incorrectly claims ^8 || ^9 || 10 core compatibility and fixed whatever mistake was there .Kindly review the patch file .
Comment #11
shreya_th commentedIgnore the previous patch file . Kindly review the updated patch file in that i have made changes in info.yml for incorrectly claims ^8 || ^9 || 10 core compatibility and fixed whatever mistake was there .
Comment #12
rushikesh raval commented@Shreya_th for which version you have provided patch. I have reviewed patch manually. I think it is for .info file. which is for Drupal 7.
Comment #13
shreya_th commented@rushiraval for drupal 9 and drupal 10 .
Comment #14
gábor hojtsyOpened a 2.x to clean this up and only claim compatibility with tested versions.
Comment #17
gábor hojtsy