Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
You have a few options for how to use this issue:
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.
You can use Drupal Rector yourself to make these patches.
If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.
Using the patches
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | potx-drupal-10-compatibility-3285613-18.patch | 9.54 KB | watergate |
| #16 | potx-3285613.patch | 7.27 KB | prudloff |
| #13 | 3285613-13.patch | 16.53 KB | ravimane23 |
| #9 | 3285613-9.patch | 15.83 KB | gábor hojtsy |
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
gábor hojtsyHere is only the twig parts of the patch which could not be automated.
Comment #4
gábor hojtsyAlso including the fix for drupal_get_path() which seems to be the only thing left other than the tests.
Comment #5
gábor hojtsyMerged with the rector patch. Added back the pass() equivalent for debugging.
Comment #6
gábor hojtsyAnd finally update our info file. This should be testable on a composer path repo since we also have a composer.json already. Fingers crossed.
Comment #7
gábor hojtsyThat did not help test on Drupal 10. What if we also make a superfluous modification to the composer file?
Comment #8
gábor hojtsyAnd assertEqual() should be assertEquals().
Comment #9
gábor hojtsyLet's get better errors for the failing test.
Comment #10
gábor hojtsyI think we are well ahead that we don't need further bot patches here, but the remaining one fail needs to be resolved. For some reason we have one more error on the twig/config parsing job than expected.
Comment #11
gábor hojtsyComment #12
ravimane23 commentedComment #13
ravimane23 commentedI can see there is one module which is used for phpunittest.
Submitted the patch for the same. Hope test will pass now.
Comment #14
gábor hojtsyYeah that is a specific test module I would not update, since that is meant to test Drupal 8/9 compatibility, not 10.
Comment #15
ravimane23 commentedComment #16
prudloff commentedIn case anyone needs it, here is a patch that you can apply cleanly on 1.0.0-alpha1 if you need to use it on Drupal 10.
It does not patch tests, so only use it if you don't need to run tests.
Comment #17
watergate commentedI've updated the patch of #16 to apply to the current dev version.
Comment #18
watergate commentedSince
count()throws an exception when an invalid countable type is passed as a value (in PHP 8), I've updated the patch to ensure an empty array is provided when the variable is NULL:count($strings ?? []).Comment #19
lendudeAdded the patch from #18, extracted translations for the potx module through the UI, no issues found
Installed Drush 11, ran
drush potx single(so extracted strings from all of core, that should hit most use cases I would think), seems to work great.Comment #21
gábor hojtsyPatch looks good on a visual review. Thanks for manually testing it. Committing and then we'll see automated test results :)
Comment #22
gábor hojtsy@Lendude is working on followup tasks in #3347587: Make the test suite pass on Drupal10/PHP8.1.