Closed (fixed)
Project:
Simple Password Reset
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2023 at 07:25 UTC
Updated:
17 Jul 2026 at 12:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
michael.acampora commentedAttached patch that implements solution to skip simple pass reset when guardian is used for guarded accounts.
Comment #3
michael.acampora commentedUpdated patch to be compatible with 1.3
Comment #4
tim-dielsSo if I understand correctly, the 2 modules can work next to each other but should not do anything when Guardian is activated for an account? Would be good to have some kind of test or at least someone else can review this?
Comment #6
astonvictor commentedComment #7
astonvictor commentedI tested the patch and it works ok.
e.g. created a reset password link for the user 1 and can see the default button on the page. Then created the same reset password link for user 2 and can see the password field on the page.
As for me, the Guardian looks strange. It only has 160 usages, and it requires writing custom code.
e.g.
- you should implement
hook_guardian_guarded_users()function to add other users (no UI);- you cannot skip user 1 from protection, and there is no validation if the user exists;
- you should implement a hook/event to trigger the
resetGuardedUsers()method to update the list of users.The contrib module should not work in that way.
Comment #10
astonvictor commented