Problem/Motivation

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.

The module also uses an interface first introduced in 9.1 (See https://www.drupal.org/node/3151009)

Steps to reproduce

Try installing in D8 versions < 8.8

Proposed resolution

we should restrict the version by replacing core_version_requirement: ^9.1 || ^10

https://www.drupal.org/docs/develop/creating-modules/let-drupal-know-abo...

Issue fork current_page_crumb-3354782

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omkar_yewale created an issue. See original summary.

omkar_yewale opened merge request !6

omkar_yewale’s picture

omkar_yewale commented
Assigned: omkar_yewale » Unassigned
Issue summary: View changes
Status: Needs work » Needs review

!6 MR Created, Please Review.

Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Reviewed & tested by the community

This looks good to me.

can be moved to RTBC.

ericgsmith made their first commit to this issue’s fork.

ericgsmith’s picture

ericgsmith commented
Status: Reviewed & tested by the community » Needs review

Sorry to hijack the issue, but 9.1 is the min support version after change for D10.

See https://www.drupal.org/node/3151009

ericgsmith’s picture

ericgsmith commented
Title: The core_version_requirement was not recognized before version 8.7.7 » The core_version_requirement is incorrect
Issue summary: View changes
Manoj Raj.R’s picture

Manoj Raj.R commented
Status: Needs review » Reviewed & tested by the community

This looks good to me.

can be moved to RTBC.

Greg Boggs made their first commit to this issue’s fork.

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented

greg boggs’s picture

greg boggs
he/him
Primary language English
Location Portland Oregon
commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.