Problem/Motivation

FILE: .../www/html/contribution/drupal10/web/themes/contrib/claro_compact/README.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 85 characters
7 | WARNING | Line exceeds 80 characters; contains 90 characters
8 | WARNING | Line exceeds 80 characters; contains 91 characters
11 | WARNING | Line exceeds 80 characters; contains 97 characters
12 | WARNING | Line exceeds 80 characters; contains 105 characters
--------------------------------------------------------------------------------

FILE: .../html/contribution/drupal10/web/themes/contrib/claro_compact/css/style.css
--------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
22 | ERROR | [x] Multiple selectors should each be on a single line
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
112 | ERROR | [x] Multiple selectors should each be on a single line
112 | ERROR | [x] Multiple selectors should each be on a single line
137 | ERROR | [x] Multiple selectors should each be on a single line
141 | ERROR | [x] Multiple selectors should each be on a single line
142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
178 | ERROR | [x] Multiple selectors should each be on a single line
196 | ERROR | [x] Multiple selectors should each be on a single line
234 | ERROR | [x] Multiple selectors should each be on a single line
272 | ERROR | [x] Multiple selectors should each be on a single line
294 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...contribution/drupal10/web/themes/contrib/claro_compact/claro_compact.theme
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
9 | WARNING | Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
--------------------------------------------------------------------------------

FILE: ...tion/drupal10/web/themes/contrib/claro_compact/claro_compact.libraries.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 470ms; Memory: 10MB

Steps to reproduce

Download the theme, and execute the command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig claro_compact/

Proposed resolution

Fix all the issues for Drupal and DrupalPractice standards

Remaining tasks

Patch review.

CommentFileSizeAuthor
coding-standard-fixes.patch5.06 KBurvashi_vora

Comments

urvashi_vora created an issue. See original summary.

djg_tram’s picture

djg_tram commented

The indentation typos are clear but, to tell you frankly, I probably can't be forced to change the 80-line. I consider it one of the stupidest assumptions in 2023 and fight it tooth and nail in other languages and IDEs as well. People don't use 80-line VGA terminals any more, neither do I, there's absolutely no sense in this requirement, quite the opposite, it makes contemporary programming a pain.

I'm a very strong proponent of legible, well organized code but this just flies in the face of all that.

djg_tram’s picture

djg_tram commented
Status: Needs review » Fixed
djg_tram’s picture

djg_tram commented
Status: Fixed » Closed (fixed)
ressa’s picture

ressa
he/him
commented

I agree, and quoted you in #3173782-18: Increase line length limit to 120 :)

djg_tram’s picture

djg_tram commented

Thanks. I probably won't chime in there because, frankly, I can't be bothered, I just ignore it. And, as far as I can see, nobody argues for it, anyway... :-))

ressa’s picture

ressa
he/him
commented

True, and your view point has already been heard :)