Problem/Motivation

SF pull does not check if the item is already in the queue.

Steps to reproduce

Run salesforce_pull_cron then go and reset `Pull Settings` - `Last Pull date` on `Salesforce Mappings` and then run salesforce_pull_cron again

Proposed resolution

Create a new Event of the type PULL_ENQUEUE and dispatch it in enqueueResultSet() and check if isEnqueueAllowed.

Remaining tasks

REVIEW

User interface changes

NONE

API changes

NONE

Data model changes

NONE

CommentFileSizeAuthor
#4 feature_new_pull_enqueue_event_with_dispatch.patch5.65 KBdejan.maric.max
#2 feature_new_pull_enqueue_event_with_dispatch.patch5.96 KBdejan.maric.max
feature_new_pull_enqueue_event_with_dispatch.patch6.01 KBdejan.maric.max

Comments

dejan.maric.max created an issue. See original summary.

dejan.maric.max’s picture

dejan.maric.max commented
StatusFileSize
new feature_new_pull_enqueue_event_with_dispatch.patch5.96 KB

Seems as the first upload had the:
{"buildLabel":"Patch Failed to Apply","buildDetails":"fatal: git apply: bad git-diff - expected \/dev\/null on line 10"}

Status: Needs review » Needs work

The last submitted patch, 2: feature_new_pull_enqueue_event_with_dispatch.patch, failed testing. View results

dejan.maric.max’s picture

dejan.maric.max commented
StatusFileSize
new feature_new_pull_enqueue_event_with_dispatch.patch5.65 KB

Fixed failed testing.

dejan.maric.max’s picture

dejan.maric.max commented
Status: Needs work » Needs review

aaronbauman’s picture

aaronbauman
he/him
commented
Status: Needs review » Fixed

I like it, thanks for the patch.
committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.