Problem/Motivation

Getting following error/warnings.
FILE: /web/modules/contrib/login_time_restriction/tests/src/Functional/AccessTimeSettingsTest.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | Unused variable $target_entity.
------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /web/modules/contrib/login_time_restriction/login_time_restriction.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
162 | WARNING | [x] '@TODO Replace FALSE value with config value.' should match the format '@todo Fix problem X here.'
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

Time: 916ms; Memory: 12MB

Steps to reproduce

Run following command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/login_time_restriction/

Proposed resolution

Above error/warnings need to be fixed.

CommentFileSizeAuthor
#4 3353980 - after.png112.48 KBkenyoowen
#4 3353980 - before.png147.7 KBkenyoowen

Issue fork login_time_restriction-3353980

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mukesh88 created an issue. See original summary.

mukesh88 opened merge request !1

mukesh88’s picture

mukesh88 commented
Assigned: mukesh88 » Unassigned
Status: Needs work » Needs review
kenyoowen’s picture

kenyoowen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3353980 - before.png147.7 KB
new 3353980 - after.png112.48 KB

Hi mukesh88

I applied your MR in my local and confirmed that the warnings are resolved. Please see the screenshots attached.

For your review.
Thank you.

kunal_singh made their first commit to this issue’s fork.

kunal_singh’s picture

kunal_singh commented

Apologies for the multiple changes. The Pipeline was not configured. I did that and things are working fine now.

Thanks @mukesh88 & @kenyoOwen for the contribution.

kunal_singh’s picture

kunal_singh commented
Status: Reviewed & tested by the community » Fixed
kunal_singh’s picture

kunal_singh commented
Status: Fixed » Closed (fixed)