Problem/Motivation

The claro/drupal.responsive-detail library does not seem to be used anywhere.

Steps to reproduce

Proposed resolution

Remove it
Find where it should be used and add it where necessary.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3353612-2.patch489 bytesgauravvvv

Issue fork drupal-3353612

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nod_ created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3353612-2.patch489 bytes

I have removed claro/drupal.responsive-detail library. As it is no longer in use. please review

tanuj.’s picture

tanuj. commented

Verified and tested patch #2, looks good to me as it removed the unused 'claro/drupal.responsive-detail' library. RTBC +1

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative

Searching for it here http://grep.xnddx.ru/search?text=claro%2Fdrupal.responsive-detail&filename= and see the template it use to be apart of.

Was removed in #3061042: Status Report Page Update. Do we want to check if it should be added back?

The js file is also not being used anymore

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !3829

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

I deleted the library entry and the JS file. Please review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Guess if no one can see a reason to keep removing is fine.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs manual testing

We should check that the removal was intentional and there hasn't been a regression.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Tested on node edit screen with a number of detail tags and I didn't see anything change. Believe this was dead code as the library was never loaded.

  • catch committed 92cb79aa on 10.1.x 
    Issue #3353612 by rpayanm, Gauravvvv, smustgrave, nod_: Remove or fix...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

OK given this really looks like dead code let's go ahead and remove it. Committed/pushed to 10.1.x, thanks!

quietone’s picture

quietone commented
Issue tags: -Needs manual testing

smustgrave tested this in #10, therefor removing the testing tag.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.