Problem/Motivation

Currently on EBT core there is a design options that is being used for other EBT projects and it's working fine. The drop-down for border style works fine with multiple options. It's clear for developers that understand css, however for CMS editors that don't are familiar with that will need to select the options to understand how it works. In order to helps the content owners we can provide a description with the explanation, like this one: https://developer.mozilla.org/en-US/docs/Web/CSS/border-style

Steps to reproduce

Proposed resolution

  1. Implements the Form API
  2. Add the description field that is missing
  3. Include the information about border styles
  4. Use the StringTranslationInterface to make it available to be translated at user translation interface
  5. But the link for Mozilla Developers where there is a demo

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Border-style-after.png155.5 KBomkar_yewale
#5 Border-style-before.png24.72 KBomkar_yewale

Issue fork ebt_core-3351981

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

RenatoG created an issue. See original summary.

RenatoG opened merge request !40

renatog’s picture

renatog commented
Issue summary: View changes
Status: Active » Needs review

Implemented. MR is available at: https://git.drupalcode.org/project/ebt_core/-/merge_requests/40

omkar_yewale’s picture

omkar_yewale commented
Assigned: Unassigned » omkar_yewale
Priority: Normal » Minor
omkar_yewale’s picture

omkar_yewale commented
Assigned: omkar_yewale » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Border-style-before.png24.72 KB
new Border-style-after.png155.5 KB

Hi RenatoG, The MR looks good and is working as expected, so moving to RTBC.

  • RenatoG authored 34dac87c on 1.4.x 
    Issue #3351981: Adding a missing description for the Border Styles at...
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented

Hi Renato, thank you!

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Reviewed & tested by the community » Fixed
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)