Problem/Motivation

Inside of EBT core is there a bunch of design options that is being used for many other EBT projects and it's nice. However inside of ebt_core is there an option to edge to edge checkbox and there is no descriptions for this. I was asked about that in the PoC and I wasn't really sure to explain besides the name. So I tested that and I realized that checking it the CSS generated will add the class .ebt-edge-to-edge and it'll apply from left to right in the entire screen. Now it's clear for me so I'd suggest using the description to explain that for the CMS editors that don't have familiarity accessing in the code

Steps to reproduce

Proposed resolution

  1. Implement the #description in the #Form API class
  2. Put a description for Edge to Edge
  3. Remember to use StringTranslationInterface to make it available at User translate interface

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 EBT-Description-After.png74.94 KBomkar_yewale
#5 EBT-Description-Before.png57.31 KBomkar_yewale

Issue fork ebt_core-3351966

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

RenatoG created an issue. See original summary.

RenatoG opened merge request !39

renatog’s picture

renatog commented
Status: Active » Needs review

Fixed. MR is available at: https://git.drupalcode.org/project/ebt_core/-/merge_requests/39

omkar_yewale’s picture

omkar_yewale commented
Assigned: Unassigned » omkar_yewale
Priority: Normal » Minor
omkar_yewale’s picture

omkar_yewale commented
Assigned: omkar_yewale » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new EBT-Description-Before.png57.31 KB
new EBT-Description-After.png74.94 KB

Hi RenatoG, The MR looks good and is working as expected, so moving to RTBC.

levmyshkin made their first commit to this issue’s fork.

  • levmyshkin committed 12b99521 on 1.4.x authored by RenatoG 
    Issue #3351966: Provide help text description for the edge to edge...
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented

Hi Renato, thank you!

levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Reviewed & tested by the community » Fixed
levmyshkin’s picture

levmyshkin
Location Novi Sad, Serbia
commented
Status: Fixed » Closed (fixed)