Problem/Motivation

When access check function has been performed, negate is not consider in the check.

Steps to reproduce

- set expiration date and time for the block,
- check the expiration time to pass,
- block is hidden and this is ok behaviour,
- set negate for the expiration date,
- block is still hidden (this is not expected behaviour)

Proposed resolution

Negate should be consider in block access check function.

CommentFileSizeAuthor
#4 3351861-afterPatch.png63.79 KBclarkssquared
#4 3351861-beforePatch.png65.44 KBclarkssquared
#2 block_scheduler_negate_consider_access-3351861-1.patch530 bytessakiland

Comments

sakiland created an issue. See original summary.

sakiland’s picture

sakiland commented
StatusFileSize
new block_scheduler_negate_consider_access-3351861-1.patch530 bytes

Here's the patch

geoanders’s picture

geoanders commented
Version: 2.0.1 » 2.0.x-dev
Status: Active » Needs review
clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3351861-beforePatch.png65.44 KB
new 3351861-afterPatch.png63.79 KB

Hi sakiland,

I confirmed the issue was resolved when I applied patch #2 to the "Block Scheduler" module against Version 2.0.x-dev.

Please see the screenshots attached.

For your review.
Thank you.

robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks. Applied. in -dev.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.