Getting following error/warnings.
FILE: /var/www/html/modules/contrib/content_remote_options/tests/modules/content_remote_options_test/content_remote_options_test.routing.yml
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/modules/contrib/content_remote_options/src/Plugin/Field/FieldWidget/ListRemoteOptionsSelectWidget.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /var/www/html/modules/contrib/content_remote_options/src/Plugin/Field/FieldType/ListRemoteOptionsItem.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
229 | WARNING | Unused variable $k.
---------------------------------------------------------------------------------------------------------------
Time: 2.09 secs; Memory: 6MB
Run following command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/content_remote_options/
Above error/warnings need to be fixed.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screenshot 2023-04-03 at 1.31.03 PM.png | 62.22 KB | ashutosh ahirwal |
| #2 | 3351803-2.patch | 1.86 KB | samitk |
Comments
Comment #2
samitk commentedAbove errors/warnings has been fixed.
Comment #3
ashutosh ahirwal commentedPatch get applied cleanly.
Comment #4
avpadernoThe patch could apply, but it is not correct.
Comments are sentences, which means they end with a period.
That comment can be better written, for example Since this is a test route, it does not require a specific permission to be accessed.
I would rather ignore the report, since that is a route defined in a test module, which by definition is not accessed outside tests.
Comment #5
tiagozThanks for the contribution. The patch was committed and it's already available on the last release 1.1.2.
Comment #6
tiagoz