Problem/Motivation

$ yarn outdated
Package                   Current Wanted  Latest   
eslint                    8.29.0  8.37.0  8.37.0   
eslint-config-prettier    8.5.0   8.8.0   8.8.0    
eslint-plugin-import      2.26.0  2.27.5  2.27.5   
eslint-plugin-yml         1.2.0   1.5.0   1.5.0

Steps to reproduce

Proposed resolution

cd core
yarn
yarn upgrade eslint eslint-config-prettier eslint-plugin-import eslint-plugin-yml
yarn lint:core-js-passing

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 yarn-lock-updated-3351618-8.patch48.78 KBgauravvvv
#6 3351618-4.patch590 bytessantosh_verma
#2 3351618-2.patch48.9 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Active » Needs review
StatusFileSize
new 3351618-2.patch48.9 KB
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Ditto for #3344087: Update Stylelint and Prettier for Drupal 10.1 and use Prettier for formatting PostCSS

Assuming if updating the package broke it would of been caught by the build.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll.

santosh_verma’s picture

santosh_verma commented
Assigned: Unassigned » santosh_verma
santosh_verma’s picture

santosh_verma commented
Assigned: santosh_verma » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3351618-4.patch590 bytes

I am re-rolling the patch against #2, Please review

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue summary: View changes
Status: Needs review » Needs work

The patch only upgrades the version of yaml. Did you follow the steps in the "proposed resolution" in the issue summary?

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
StatusFileSize
new yarn-lock-updated-3351618-8.patch48.78 KB

I have re-rolled the patch for 10.1.x. please review

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

#8 looks like a good reroll.

Removing credit for #6 as it was missing majority of the updates.

  • catch committed 084b8fc5 on 10.1.x 
    Issue #3351618 by longwave, Gauravvvv: Update ESLint and related...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This conflicted again due to a revert elsewhere, but #1 still applied cleanly, so I have committed that!

Committed 084b8fc and pushed to 10.1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.