Problem/Motivation

Amongst the current suppressions found in the PHPStan level 1 baseline, introduce by the adding of phpstan/phpstan-phpunit, is: You should use assertNull() instead of assertSame(null, $actual)..

This issue exists to fix all of those.

Steps to reproduce

- Run PHPStan on level 1 and see the above issue amongst all others.

Proposed resolution

- Solve all of the reported issues for the above mentioned.
- Run PHPStan on level 1 and don't see the above issue any more.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3351060

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !3743

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Needs review » Reviewed & tested by the community

PHPStan recommended fixes, reducing the baseline. Thanks.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 336c3ef and pushed to 10.1.x. Thanks!

  • catch committed 336c3ef2 on 10.1.x 
    Issue #3351060 by Spokje: Fix PHPStan L1 errors "You should use...
catch’s picture

catch
he/him
Primary language English
commented

Spokje closed merge request !3743

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.