Problem/Motivation

In Drupal.eu_cookie_compliance.declineAction, when popup is on page top and not fixed, the behavior is buggy.
When the user accepts the cookies, the popup slides top then, at the moment it's removed from DOM, the body top margin is reset.
When the user declines the cookies, the popup slides top then the body top margin is not reset when the popup is hidden (display: none).
It causes the page header to be pulled out of the top of the page.

Proposed resolution

Reset body margin when we hide the popup on decline.

CommentFileSizeAuthor
#4 eucc_after.mp4836.84 KBduaelfr
#4 eucc_before.mp4684.9 KBduaelfr

Issue fork eu_cookie_compliance-3350586

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DuaelFr created an issue. See original summary.

DuaelFr opened merge request !120

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
Status: Active » Needs review
duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented
StatusFileSize
new eucc_before.mp4684.9 KB
new eucc_after.mp4836.84 KB

Added before/after screenshares

svenryen made their first commit to this issue’s fork.

  • svenryen committed 36ac9ad2 on 8.x-1.x authored by DuaelFr 
    Issue #3350586 by DuaelFr, svenryen: Declined cookies with top popup...
svenryen’s picture

svenryen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.